8266400: importkeystore fails to a password less pkcs12 keystore

[haimaychao]

Please review the fix to address keytool -importkeystore failure when importing to a password-less PKCS12 keystore.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266400: importkeystore fails to a password less pkcs12 keystore

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4119/head:pull/4119
$ git checkout pull/4119

Update a local copy of the PR:
$ git checkout pull/4119
$ git pull https://git.openjdk.java.net/jdk pull/4119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4119

View PR using the GUI difftool:
$ git pr show -t 4119

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4119.diff

[bridgekeeper]

👋 Welcome back hchao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@haimaychao The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (03d0ec4f)

[openjdk]

@haimaychao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266400: importkeystore fails to a password less pkcs12 keystore

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 90 new commits pushed to the master branch:

• f5562f1: 8258535: jvm.ClassReader should set the accessor to the corresponding record component
• d8e6e28: 8267544: (test) rmi test NonLocalSkeleton fails if network has multiple adapters with the same address
• f453166: 8267578: Remove unnecessary preview checks
• 49f622c: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on
• 54520fb: 8267580: The method JavacParser#peekToken is wrong when the first parameter is not zero
• 3113910: 8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry()
• 4d26f22: 8264304: Create implementation for NSAccessibilityToolbar protocol peer
• 6288a99: 8267404: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java failed with OutOfMemoryError
• 71e2fa2: 8267531: [x86] Assembler::andb(Address,Register) encoding is incorrect
• 4023646: 8266528: Optimize C2 VerifyIterativeGVN execution time
• ... and 80 more: https://git.openjdk.java.net/jdk/compare/cd1c17c0a6416a8d16cf2035f3e97dba95b6b8af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[haimaychao]

/integrate

[openjdk]

@haimaychao Since your change was applied there have been 90 commits pushed to the master branch:

• f5562f1: 8258535: jvm.ClassReader should set the accessor to the corresponding record component
• d8e6e28: 8267544: (test) rmi test NonLocalSkeleton fails if network has multiple adapters with the same address
• f453166: 8267578: Remove unnecessary preview checks
• 49f622c: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on
• 54520fb: 8267580: The method JavacParser#peekToken is wrong when the first parameter is not zero
• 3113910: 8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry()
• 4d26f22: 8264304: Create implementation for NSAccessibilityToolbar protocol peer
• 6288a99: 8267404: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java failed with OutOfMemoryError
• 71e2fa2: 8267531: [x86] Assembler::andb(Address,Register) encoding is incorrect
• 4023646: 8266528: Optimize C2 VerifyIterativeGVN execution time
• ... and 80 more: https://git.openjdk.java.net/jdk/compare/cd1c17c0a6416a8d16cf2035f3e97dba95b6b8af...master

Your commit was automatically rebased without conflicts.

Pushed as commit f2d880c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.