New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253736: Cleanup some of WorkArounds and usage thereof #412
8253736: Cleanup some of WorkArounds and usage thereof #412
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons this pull request can not be integrated into git checkout 8253736-workarounds
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@jonathan-gibbons The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a nit comment, no need for another iteration, the changes looks good to me
// info from a doclet to its taglets via a doclet-specific subtype of | ||
// DocletEnvironment. | ||
toolEnv = ((DocEnvImpl)this.configuration.docEnv).toolEnv; | ||
javacTypes = toolEnv.getTypes(); | ||
} | ||
|
||
/* | ||
* TODO: This method exists because of a bug in javac which does not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably a good idea to include the bug ID here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vicente-romero-oracle This relates to a discussion we should have elsewhere, separately, about the interactions between deprecation and packages, and whether we should support depicted packages. JLS does not list packages in the list of kinds of elements that can be deprecated, in which case this comment is probably incorrect, as the bug may actually be here in javadoc for trying to support deprecated packages!
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 62 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/reviewers 2 |
@jonathan-gibbons |
@vicente-romero-oracle thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see WorkArounds being chipped away. It is not clear to me if additional tests are warranted for getConstantValue for TestConstantValuesDriver.java, in langtools test I saw only ElementStructureTest.java. I will leave it to you, maybe file a follow up issue.
public String visitPrimitiveAsBoolean(PrimitiveType t, Object val) { | ||
return (int)val == 0 ? "false" : "true"; | ||
} | ||
return cve.visit(ve.asType(), ve.getConstantValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay
@@ -57,15 +57,15 @@ public void test() { | |||
""" | |||
<code id="TestConstantValues.BYTE_MAX_VALUE">public static final byte</code></td> | |||
<th class="col-second" scope="row"><code><a href="TestConstantValues.html#BYTE_MAX_VALUE">BYTE_MAX_VALUE</a></code></th> | |||
<td class="col-last"><code>127</code></td>""", | |||
<td class="col-last"><code>0x7f</code></td>""", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be tests for Float, Double, Long ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/integrate |
@jonathan-gibbons Since your change was applied there have been 62 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7778047. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This cleanup is primarily focussed on the WorkArounds class, simplifying/removing code that is no longer required.
Also, simplified DocLint initialization such that it no longer needs a
JavacTask
and so the initialization code can be moved out ofWorkArounds
.The "constant value expression" in Utils is simplified to remove a redundant level of enclosing nested class for the type-kind visitor.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/412/head:pull/412
$ git checkout pull/412