Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8267434: Remove LinkOutput[Impl] #4121

Closed
wants to merge 1 commit into from

Conversation

@jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented May 19, 2021

Please review a trivial patch to remote an unused internal interface and its implementation.

I've looked as far back as JDK 8, and the code was unused even back then.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4121/head:pull/4121
$ git checkout pull/4121

Update a local copy of the PR:
$ git checkout pull/4121
$ git pull https://git.openjdk.java.net/jdk pull/4121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4121

View PR using the GUI difftool:
$ git pr show -t 4121

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4121.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 19, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc label May 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 19, 2021

Webrevs

@pavelrappo
Copy link
Member

@pavelrappo pavelrappo commented May 20, 2021

@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented May 20, 2021

This might be familiar: https://bugs.openjdk.java.net/browse/JDK-8011642

Yes, see the full archaeology in the comments for this issue, https://bugs.openjdk.java.net/browse/JDK-8267434

@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267434: Remove LinkOutput[Impl]

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 9425d3d: 8261880: Change nested classes in java.base to static nested classes where possible
  • 459abd5: 8267219: Javadoc method summary breaks when {@inheritdoc} from an empty parent
  • aba2265: 8260267: ZGC: Reduce mark stack usage
  • f979523: 8267463: Problemlist runtime/os/TestTracePageSizes.java on linux-aarch64 to reduce noise
  • f07dcf4: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer
  • 31320c3: 8267262: com/sun/net/httpserver/Filter improve API documentation of static methods
  • 7dcb9fd: 8265684: implement Sealed Classes as a standard feature in Java, javadoc changes
  • 0fa9223: 8260517: implement Sealed Classes as a standard feature in Java
  • 31b98e1: 8265319: implement Sealed Classes as a standard feature in Java, javax.lang.model changes
  • 726785b: 8267155: runtime/os/TestTracePageSizes times out
  • ... and 1 more: https://git.openjdk.java.net/jdk/compare/b961f2535c9508d6f8e580b8bf53538d6f72b27c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 20, 2021
@jonathan-gibbons
Copy link
Contributor Author

@jonathan-gibbons jonathan-gibbons commented May 20, 2021

/integrate

@openjdk openjdk bot closed this May 20, 2021
@openjdk openjdk bot added integrated and removed ready labels May 20, 2021
@jonathan-gibbons jonathan-gibbons deleted the LinkOutput branch May 20, 2021
@openjdk openjdk bot removed the rfr label May 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@jonathan-gibbons Since your change was applied there have been 12 commits pushed to the master branch:

  • fc7f0a3: 8267480: Explicitly problemlist all runtime/os/TestTracePageSizes.java tests on linux-aarch64 to reduce noise
  • 9425d3d: 8261880: Change nested classes in java.base to static nested classes where possible
  • 459abd5: 8267219: Javadoc method summary breaks when {@inheritdoc} from an empty parent
  • aba2265: 8260267: ZGC: Reduce mark stack usage
  • f979523: 8267463: Problemlist runtime/os/TestTracePageSizes.java on linux-aarch64 to reduce noise
  • f07dcf4: 8264290: Create implementation for NSAccessibilityComponentGroup protocol peer
  • 31320c3: 8267262: com/sun/net/httpserver/Filter improve API documentation of static methods
  • 7dcb9fd: 8265684: implement Sealed Classes as a standard feature in Java, javadoc changes
  • 0fa9223: 8260517: implement Sealed Classes as a standard feature in Java
  • 31b98e1: 8265319: implement Sealed Classes as a standard feature in Java, javax.lang.model changes
  • ... and 2 more: https://git.openjdk.java.net/jdk/compare/b961f2535c9508d6f8e580b8bf53538d6f72b27c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 878d1b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants