-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267463: Problemlist runtime/os/TestTracePageSizes.java on linux-aarch64 to reduce noise #4125
8267463: Problemlist runtime/os/TestTracePageSizes.java on linux-aarch64 to reduce noise #4125
Conversation
👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into |
@tschatzl To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thomas,
Not sure if you can just list the with-serial case?
But I'm fine with rejecting the whole test if needed.
Thanks,
David
/integrate |
@tschatzl This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks @dholmes-ora for the review. I thought it's only one architecture anyway, and it is very suspicious to me that only serial gc fails. |
Hi,
can I have reviews for this trivial(?) problemlisting of a test?
Thanks,
Thomas
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4125/head:pull/4125
$ git checkout pull/4125
Update a local copy of the PR:
$ git checkout pull/4125
$ git pull https://git.openjdk.java.net/jdk pull/4125/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4125
View PR using the GUI difftool:
$ git pr show -t 4125
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4125.diff