Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263332: JFR: Dump recording from a recording stream #4126

Closed
wants to merge 3 commits into from

Conversation

@egahlin
Copy link
Member

@egahlin egahlin commented May 20, 2021

Hi,

Could I have a review of an enhancement that add a dump method to RecordingStream and RemoteRecordingStream.

Testing: tier1 + tier2, jdk/jdk/jfr a few hundred times to rule out intermittent failures.

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263332: JFR: Dump recording from a recording stream

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4126/head:pull/4126
$ git checkout pull/4126

Update a local copy of the PR:
$ git checkout pull/4126
$ git pull https://git.openjdk.java.net/jdk pull/4126/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4126

View PR using the GUI difftool:
$ git pr show -t 4126

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4126.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 20, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot-jfr label May 20, 2021
@egahlin
Copy link
Member Author

@egahlin egahlin commented May 20, 2021

/csr

Loading

@openjdk openjdk bot added the csr label May 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@egahlin has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@egahlin please create a CSR request for issue JDK-8266266. This pull request cannot be integrated until the CSR request is approved.

Loading

@egahlin egahlin changed the title 8266266 JFR: Dump recording from a recording stream 8263332: JFR: Dump recording from a recording stream May 20, 2021
@egahlin egahlin marked this pull request as ready for review May 20, 2021
@openjdk openjdk bot added the rfr label May 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 20, 2021

Webrevs

Loading

@openjdk openjdk bot removed the csr label May 26, 2021
Copy link

@mgronlun mgronlun left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 31, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263332: JFR: Dump recording from a recording stream

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 176 new commits pushed to the master branch:

  • 4767758: 8267920: Create separate Events buffer for VMOperations
  • dc19bac: 8268094: Some vmTestbase/nsk tests fail after ACC_STRICT/strictfp changes
  • 2963c9e: 8268103: JNI functions incorrectly return a double after JDK-8265836
  • 6765f90: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal
  • 19450b9: 8266281: Assign Symbols to the package selector expression
  • a223189: 8264774: Implementation of Foreign Function and Memory API (Incubator)
  • 71425dd: 8267118: OutOfMemoryError cannot be caught as a Throwable
  • de6472c: 8267459: Pasting Unicode characters into JShell does not work.
  • 9247630: 8265270: Type.getEnclosingType() may fail with CompletionFailure
  • 2d494bf: 8267836: Separate eager reclaim remembered set threshold from G1RSetSparseRegionEntries
  • ... and 166 more: https://git.openjdk.java.net/jdk/compare/8e3549fc736539a45534dfe2b417170b5c991c7d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 31, 2021
@egahlin
Copy link
Member Author

@egahlin egahlin commented Jun 2, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@egahlin Since your change was applied there have been 181 commits pushed to the master branch:

  • b7ac705: 8263642: javac emits duplicate checkcast for first bound of intersection type in cast
  • e1462e7: 8267176: StandardDoclet should provide access to Reporter and Locale
  • 56b65e4: 8267569: java.io.File.equals contains misleading Javadoc
  • 508cec7: 8267521: Post JEP 411 refactoring: maximum covering > 50K
  • 40d23a0: 8267543: Post JEP 411 refactoring: security
  • 4767758: 8267920: Create separate Events buffer for VMOperations
  • dc19bac: 8268094: Some vmTestbase/nsk tests fail after ACC_STRICT/strictfp changes
  • 2963c9e: 8268103: JNI functions incorrectly return a double after JDK-8265836
  • 6765f90: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal
  • 19450b9: 8266281: Assign Symbols to the package selector expression
  • ... and 171 more: https://git.openjdk.java.net/jdk/compare/8e3549fc736539a45534dfe2b417170b5c991c7d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1ae934e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants