Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267459: Pasting Unicode characters into JShell does not work. #4128

Closed
wants to merge 3 commits into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented May 20, 2021

The NonBlockingInputStreamReader.readBuffered method will read some bytes from the InputStream, and then try to convert them to characters. But, the input array may end in the middle of a sequence - e.g. it may end with a part of UTF-8 sequence, which will be only finished when the input is read next time.

The proposed fix is to store the trailing unused bytes into the bytes field, which is already used for a similar purpose by the other read method in this class, and use them on the next iteration.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267459: Pasting Unicode characters into JShell does not work.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4128/head:pull/4128
$ git checkout pull/4128

Update a local copy of the PR:
$ git checkout pull/4128
$ git pull https://git.openjdk.java.net/jdk pull/4128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4128

View PR using the GUI difftool:
$ git pr show -t 4128

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4128.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2021

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 20, 2021
@openjdk
Copy link

openjdk bot commented May 20, 2021

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label May 20, 2021
@mlbridge
Copy link

mlbridge bot commented May 20, 2021

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

lgtm!

@openjdk
Copy link

openjdk bot commented Jun 1, 2021

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267459: Pasting Unicode characters into JShell does not work.

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 36dc268: 8268036: ProblemList gtest/AsyncLogGtest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2021
@lahodaj
Copy link
Contributor Author

lahodaj commented Jun 2, 2021

/integrate

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@lahodaj Since your change was applied there have been 22 commits pushed to the master branch:

  • 9247630: 8265270: Type.getEnclosingType() may fail with CompletionFailure
  • 2d494bf: 8267836: Separate eager reclaim remembered set threshold from G1RSetSparseRegionEntries
  • bba3728: 8267726: ZGC: array_copy_requires_gc_barriers too strict
  • d47a77d: 8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly
  • 496fb90: 8267969: Add vectorized implementation for VectorMask.eq()
  • 1cea6ca: 8260360: IGV: Short name of combined nodes is hidden by background color
  • 7530c00: 8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type
  • b98e52a: 8267570: The comment of the class JavacParser is not appropriate
  • 379376f: 8265130: Make ConstantDesc class hierarchy sealed
  • 00c7aee: 8267861: Update SourceVersion with new language features in 16 and 17
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/74b70a56774e7bf716356cf38395f8e7d7dadc78...master

Your commit was automatically rebased without conflicts.

Pushed as commit de6472c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@takiguc
Copy link

takiguc commented Jul 5, 2021

/backport jdk11u-dev

@openjdk
Copy link

openjdk bot commented Jul 5, 2021

@takiguc Unknown command backport - for a list of valid commands use /help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated kulla kulla-dev@openjdk.org
3 participants