8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags #413

TheRealMDoerr · 2020-09-29T20:49:01Z

Current platform implementation (globals_ppc.hpp) uses regular product flags for almost everything.
Most platform specific flags were never intended for official support. They are only there to diagnose issues and find workarounds.
So flag kind "diagnostic" fits better for them.

Note that I rearranged a couple of lines when looking at the diff.
My actual change is what is described here: https://bugs.openjdk.java.net/browse/JDK-8253692

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags

Reviewers

Thomas Stuefe (@tstuefe - Reviewer)
Lutz Schmidt (@RealLucy - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/413/head:pull/413
$ git checkout pull/413

bridgekeeper · 2020-09-29T20:51:37Z

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2020-09-29T20:53:37Z

@TheRealMDoerr The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2020-09-29T20:57:24Z

Webrevs

00: Full (132b299)

tstuefe

Hi Martin,

make sure you check up on the places the switches are used and pass UnlockDiagnosticVMOptions.

Cheers, Thomas

tstuefe · 2020-09-30T06:53:38Z

src/hotspot/cpu/ppc/globals_ppc.hpp

          "Reoptimize code-sequences of calls at runtime.")                 \
                                                                            \
  /* Power 8: Configure Data Stream Control Register. */                    \
-  product(uint64_t,DSCR_PPC64, (uintx)-1,                                   \
+  product(uint64_t, DSCR_PPC64, (uint64_t)-1,                               \


Has nothing to do with this issue. But I leave it up to you.

Just cleanup, no real change.

tstuefe · 2020-09-30T06:54:51Z

src/hotspot/cpu/ppc/globals_ppc.hpp

  /* special instructions */                                                \
-  product(bool, UseByteReverseInstructions, false,                          \
+  product(bool, SuperwordUseVSX, false,                                     \


Why leave this one out?

SuperwordUseVSX switches usage of vector registers in C2. It's more fundamental than simple instruction usage switches. It's comparable to UseAVX on x86 which is product, too. So I prefer keeping it product for now. Are you ok with it?

Sure, just curious. Leave it up to you.

tstuefe · 2020-09-30T06:56:33Z

src/hotspot/cpu/ppc/globals_ppc.hpp

                                                                            \
-  product(bool, ZapMemory, false, "Write 0x0101... to empty memory."        \
-          " Use this to ease debugging.")                                   \


Future cleanup: this feels like it should be in shared code. The usual way to do this is to zap in DEBUG.

Yeah, sounds like this functionality derserves some overwork. But I only want to make it diagnostic with this change.

tstuefe

Looks good Martin.

RealLucy

This is an overdue cleanup. Thanks for taking care. The changes look good to me. Reviewed.

TheRealMDoerr · 2020-10-01T08:47:41Z

/integrate

openjdk · 2020-10-01T08:48:47Z

@TheRealMDoerr This PR has not yet been marked as ready for integration.

openjdk · 2020-10-01T09:18:50Z

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags

Reviewed-by: stuefe, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

1d88172: 8253682: The AppletInitialFocusTest1.java is unstable
5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes
05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
092c227: 8252523: Add ASN.1 Formatter to work with test utility HexPrinter
06d8cf6: 8253812: Cleanup AbstractMemberWriter
424d7d6: 8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor
... and 44 more: https://git.openjdk.java.net/jdk/compare/1ae6b533fbba433e64868aa3b6846041e3a91136...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

TheRealMDoerr · 2020-10-01T09:19:59Z

/integrate

openjdk · 2020-10-01T09:21:22Z

@TheRealMDoerr Since your change was applied there have been 54 commits pushed to the master branch:

1d88172: 8253682: The AppletInitialFocusTest1.java is unstable
5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes
05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
092c227: 8252523: Add ASN.1 Formatter to work with test utility HexPrinter
06d8cf6: 8253812: Cleanup AbstractMemberWriter
424d7d6: 8252881: [JVMCI] ResolvedJavaType.resolveMethod fails in fastdebug when invoked with a constructor
... and 44 more: https://git.openjdk.java.net/jdk/compare/1ae6b533fbba433e64868aa3b6846041e3a91136...master

Your commit was automatically rebased without conflicts.

Pushed as commit a824289.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8253690: [PPC64] Use flag kind diagnostic for platform specific flags

132b299

openjdk bot added the rfr Pull request is ready for review label Sep 29, 2020

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 29, 2020

tstuefe reviewed Sep 30, 2020

View reviewed changes

tstuefe approved these changes Sep 30, 2020

View reviewed changes

RealLucy approved these changes Sep 30, 2020

View reviewed changes

TheRealMDoerr changed the title ~~8253690: [PPC64] Use flag kind diagnostic for platform specific flags~~ 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags Oct 1, 2020

TheRealMDoerr changed the title ~~8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags~~ 8253690: [PPC64] Use flag kind diagnostic for platform specific flags Oct 1, 2020

TheRealMDoerr changed the title ~~8253690: [PPC64] Use flag kind diagnostic for platform specific flags~~ 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags Oct 1, 2020

openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2020

openjdk bot closed this Oct 1, 2020

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2020

TheRealMDoerr deleted the 8253690_ppc64_flags branch October 1, 2020 09:21

8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags #413

8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags #413

TheRealMDoerr commented Sep 29, 2020 •

edited by openjdk bot

bridgekeeper bot commented Sep 29, 2020

openjdk bot commented Sep 29, 2020

mlbridge bot commented Sep 29, 2020

tstuefe left a comment

tstuefe Sep 30, 2020

TheRealMDoerr Sep 30, 2020

tstuefe Sep 30, 2020

TheRealMDoerr Sep 30, 2020

tstuefe Sep 30, 2020

tstuefe Sep 30, 2020

TheRealMDoerr Sep 30, 2020

tstuefe left a comment

RealLucy left a comment

TheRealMDoerr commented Oct 1, 2020

openjdk bot commented Oct 1, 2020

openjdk bot commented Oct 1, 2020

TheRealMDoerr commented Oct 1, 2020

openjdk bot commented Oct 1, 2020

8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags #413

8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags #413

Conversation

TheRealMDoerr commented Sep 29, 2020 • edited by openjdk bot

Progress

Issue

Reviewers

Download

bridgekeeper bot commented Sep 29, 2020

openjdk bot commented Sep 29, 2020

mlbridge bot commented Sep 29, 2020

Webrevs

tstuefe left a comment

Choose a reason for hiding this comment

tstuefe Sep 30, 2020

Choose a reason for hiding this comment

TheRealMDoerr Sep 30, 2020

Choose a reason for hiding this comment

tstuefe Sep 30, 2020

Choose a reason for hiding this comment

TheRealMDoerr Sep 30, 2020

Choose a reason for hiding this comment

tstuefe Sep 30, 2020

Choose a reason for hiding this comment

tstuefe Sep 30, 2020

Choose a reason for hiding this comment

TheRealMDoerr Sep 30, 2020

Choose a reason for hiding this comment

tstuefe left a comment

Choose a reason for hiding this comment

RealLucy left a comment

Choose a reason for hiding this comment

TheRealMDoerr commented Oct 1, 2020

openjdk bot commented Oct 1, 2020

openjdk bot commented Oct 1, 2020

TheRealMDoerr commented Oct 1, 2020

openjdk bot commented Oct 1, 2020

TheRealMDoerr commented Sep 29, 2020 •

edited by openjdk bot