Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic #4137

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented May 20, 2021

A pair of trivial fixes for a couple of ObjectMonitor cleanups.

Tested with Mach5 Tier[1-3].


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic
  • JDK-8256301: ObjectMonitor::is_busy() should return bool

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4137/head:pull/4137
$ git checkout pull/4137

Update a local copy of the PR:
$ git checkout pull/4137
$ git pull https://git.openjdk.java.net/jdk pull/4137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4137

View PR using the GUI difftool:
$ git pr show -t 4137

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4137.diff

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented May 20, 2021

/issue add JDK-8256304
/issue add JDK-8256301

@bridgekeeper
Copy link

bridgekeeper bot commented May 20, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented May 20, 2021

/label add hotspot-runtime

@openjdk openjdk bot changed the title Jdk 8256304 8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic May 20, 2021
@openjdk
Copy link

openjdk bot commented May 20, 2021

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk
Copy link

openjdk bot commented May 20, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8256301: ObjectMonitor::is_busy() should return bool.

@openjdk
Copy link

openjdk bot commented May 20, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 20, 2021
@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review May 21, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label May 21, 2021
@mlbridge
Copy link

mlbridge bot commented May 21, 2021

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Thank you! Looks good!

@openjdk
Copy link

openjdk bot commented May 21, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic
8256301: ObjectMonitor::is_busy() should return bool

Reviewed-by: coleenp, pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 21, 2021
@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented May 21, 2021

@coleenp - Thanks for the review.

Copy link
Contributor

@pchilano pchilano left a comment

Looks good to me!

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented May 21, 2021

@pchilano - Thanks for the review!
Do you agree this is trivial? (I don't want to wait 24 hours...)

@pchilano
Copy link
Contributor

pchilano commented May 21, 2021

@pchilano - Thanks for the review!
Do you agree this is trivial? (I don't want to wait 24 hours...)
Yes, I agree.

@coleenp
Copy link
Contributor

coleenp commented May 21, 2021

Yes, I agree it's trivial also.

@dcubed-ojdk
Copy link
Member Author

dcubed-ojdk commented May 21, 2021

@coleenp and @pchilano - Thanks for the reviews and for concurrence on the
triviality of this fix.

/integrate

@openjdk openjdk bot closed this May 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2021
@openjdk
Copy link

openjdk bot commented May 21, 2021

@dcubed-ojdk Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit fe33343.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8256304 branch May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants