8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic

[dcubed-ojdk]

A pair of trivial fixes for a couple of ObjectMonitor cleanups.

Tested with Mach5 Tier[1-3].

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issues

• JDK-8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic
• JDK-8256301: ObjectMonitor::is_busy() should return bool

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Patricio Chilano Mateo (@pchilano - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4137/head:pull/4137
$ git checkout pull/4137

Update a local copy of the PR:
$ git checkout pull/4137
$ git pull https://git.openjdk.java.net/jdk pull/4137/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4137

View PR using the GUI difftool:
$ git pr show -t 4137

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4137.diff

[dcubed-ojdk]

/issue add JDK-8256304
/issue add JDK-8256301

[bridgekeeper]

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[dcubed-ojdk]

/label add hotspot-runtime

[openjdk]

@dcubed-ojdk The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

[openjdk]

@dcubed-ojdk
Adding additional issue to issue list: 8256301: ObjectMonitor::is_busy() should return bool.

[openjdk]

@dcubed-ojdk
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (75be6339)

[coleenp]

Thank you! Looks good!

[openjdk]

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic
8256301: ObjectMonitor::is_busy() should return bool

Reviewed-by: coleenp, pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 8f10c5a: 8267190: Optimize Vector API test operations
• 94cfeb9: 8256155: Allow multiple large page sizes to be used on Linux
• ec8a809: 8267119: switch expressions lack support for deferred type-checking
• 4ba7613: 8267332: xor value should handle bounded values
• ee2651b: 8203359: Container level resources events
• b5d32bb: 8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard
• e48d7d6: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec
• 9eaa4af: 8267056: tools/jpackage/share/RuntimePackageTest.java fails with NoSuchFileException
• e094f3f: 8266856: Make element void
• 7a63ff7: 8267370: [Vector API] Fix several crashes after JDK-8256973
• ... and 2 more: https://git.openjdk.java.net/jdk/compare/005d8a7fca8b4d9519d2bde0a7cdbbece1cd3981...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

@coleenp - Thanks for the review.

[pchilano]

Looks good to me!

[dcubed-ojdk]

@pchilano - Thanks for the review!
Do you agree this is trivial? (I don't want to wait 24 hours...)

[pchilano]

@pchilano - Thanks for the review!
Do you agree this is trivial? (I don't want to wait 24 hours...)
Yes, I agree.

[coleenp]

Yes, I agree it's trivial also.

[dcubed-ojdk]

@coleenp and @pchilano - Thanks for the reviews and for concurrence on the
triviality of this fix.

/integrate

[openjdk]

@dcubed-ojdk Since your change was applied there have been 12 commits pushed to the master branch:

• 8f10c5a: 8267190: Optimize Vector API test operations
• 94cfeb9: 8256155: Allow multiple large page sizes to be used on Linux
• ec8a809: 8267119: switch expressions lack support for deferred type-checking
• 4ba7613: 8267332: xor value should handle bounded values
• ee2651b: 8203359: Container level resources events
• b5d32bb: 8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard
• e48d7d6: 8264218: Public method javax.swing.JMenu.setComponentOrientation() has no spec
• 9eaa4af: 8267056: tools/jpackage/share/RuntimePackageTest.java fails with NoSuchFileException
• e094f3f: 8266856: Make element void
• 7a63ff7: 8267370: [Vector API] Fix several crashes after JDK-8256973
• ... and 2 more: https://git.openjdk.java.net/jdk/compare/005d8a7fca8b4d9519d2bde0a7cdbbece1cd3981...master

Your commit was automatically rebased without conflicts.

Pushed as commit fe33343.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.