Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package" #4139

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented May 21, 2021

Looks like another issue similar to hdiutil (JDK-8249395) when process is gone, but we still waiting for it. I was not able to reproduce this issue by running test or pkgbuild separately and conclusion was made based on logs. Fixed in same way as hdiutil issue. Also, I added logging PID for external commands to simplify log analysis. Log will have multiple hdiutil and/or pkgbuild processes, since we running multiple tests in parallel and matching external process to test failure requires looking at command line for particular process, so PID should simplify this.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4139/head:pull/4139
$ git checkout pull/4139

Update a local copy of the PR:
$ git checkout pull/4139
$ git pull https://git.openjdk.java.net/jdk pull/4139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4139

View PR using the GUI difftool:
$ git pr show -t 4139

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4139.diff

…th "Error: Bundler \"Mac PKG Package\" (pkg) failed to produce a package"
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 21, 2021

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@sashamatveev The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label May 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 21, 2021

Webrevs

Copy link

@andyherrick andyherrick left a comment

Please update the bug report to contain the evaluation you have here in the PR

@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package"

Reviewed-by: herrick, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • cc687fd: 8267575: Add new documentation group in HtmlStyle
  • 5a5b807: 8267633: Clarify documentation of (Doc)TreeScanner
  • 86a8f44: 8267317: Remove DeferredTypeCompleter
  • b403d39: 8267213: cpuinfo_segv is incorrectly triaged as execution protection violation on x86_32
  • 66b190e: 8267612: Declare package-private VarHandle.AccessMode/AccessType counts
  • a52c4ed: 8267110: Update java.util to use instanceof pattern variable
  • 0a03fc8: 8255674: SSLEngine class description is missing "case" in switch statement
  • d86f916: 8267066: New NSAccessibility peers should return they roles and subroles directly
  • 31d0f0d: 8248843: java in source-file mode suggests javac-only options
  • 2e8812d: 8265129: Add intrinsic support for JVM.getClassId
  • ... and 34 more: https://git.openjdk.java.net/jdk/compare/9eaa4afc99b09f4704e4d641f95104be40b9ea66...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 25, 2021
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented May 25, 2021

/integrate

@openjdk openjdk bot closed this May 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@sashamatveev Since your change was applied there have been 49 commits pushed to the master branch:

  • c20ca42: 8267691: Change table to obsolete CriticalJNINatives in JDK 18, not 17
  • e751b7b: 8267683: rfc7301Grease8F value not displayed correctly in SSLParameters javadoc
  • 0b77359: 8224243: Add implSpec's to AccessibleObject and seal Executable
  • 594d454: 8267574: Dead code in HtmlStyle/HtmlDocletWriter
  • 2ef2450: 8263445: Duplicate key compiler.err.expected.module in compiler.properties
  • cc687fd: 8267575: Add new documentation group in HtmlStyle
  • 5a5b807: 8267633: Clarify documentation of (Doc)TreeScanner
  • 86a8f44: 8267317: Remove DeferredTypeCompleter
  • b403d39: 8267213: cpuinfo_segv is incorrectly triaged as execution protection violation on x86_32
  • 66b190e: 8267612: Declare package-private VarHandle.AccessMode/AccessType counts
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/9eaa4afc99b09f4704e4d641f95104be40b9ea66...master

Your commit was automatically rebased without conflicts.

Pushed as commit 5aa45f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
3 participants