Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253689: [s390] Use flag kind "diagnostic" for platform specific flags #414

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 29, 2020

Current platform implementation (globals_s390.hpp) uses regular product flags for everything.
These platform specific flags were never intended for official support. They are only there to diagnose issues and find workarounds.
So flag kind "diagnostic" fits better.

CSR: https://bugs.openjdk.java.net/browse/JDK-8253691


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253689: [s390] Use flag kind "diagnostic" for platform specific flags

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/414/head:pull/414
$ git checkout pull/414

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2020

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 29, 2020
@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 29, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2020

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Martin,

looks simple enough. Make sure that all scripts and tests (also our internal? eg benchmarks) now pass -XX:+UnlockDiagnosticVMOptions.

Cheers, Thomas

@TheRealMDoerr
Copy link
Contributor Author

Hi Thomas,

thanks for the review. I haven't found any tests which use one of these switches. Our tests have passed.

Best regards,
Martin

Copy link
Contributor

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an overdue cleanup. Thanks for taking care. The changes look good to me. Reviewed.

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@TheRealMDoerr This PR has not yet been marked as ready for integration.

@TheRealMDoerr TheRealMDoerr changed the title 8253689: [s390] Use flag kind diagnostic for platform specific flags 8253689: [s390] Use flag kind "diagnostic" for platform specific flags Oct 1, 2020
@TheRealMDoerr TheRealMDoerr changed the title 8253689: [s390] Use flag kind "diagnostic" for platform specific flags 8253689: [s390] Use flag kind diagnostic for platform specific flags Oct 1, 2020
@TheRealMDoerr TheRealMDoerr changed the title 8253689: [s390] Use flag kind diagnostic for platform specific flags 8253689: [s390] Use flag kind "diagnostic" for platform specific flags Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253689: [s390] Use flag kind "diagnostic" for platform specific flags

Reviewed-by: stuefe, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 1, 2020
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Oct 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2020
@openjdk
Copy link

openjdk bot commented Oct 1, 2020

@TheRealMDoerr Since your change was applied there have been 55 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 7779ce9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8253689_s390_flags branch October 1, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants