8253689: [s390] Use flag kind "diagnostic" for platform specific flags

[TheRealMDoerr]

Current platform implementation (globals_s390.hpp) uses regular product flags for everything.
These platform specific flags were never intended for official support. They are only there to diagnose issues and find workarounds.
So flag kind "diagnostic" fits better.

CSR: https://bugs.openjdk.java.net/browse/JDK-8253691

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253689: [s390] Use flag kind "diagnostic" for platform specific flags

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Lutz Schmidt (@RealLucy - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/414/head:pull/414
$ git checkout pull/414

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TheRealMDoerr The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ebfdc3e)

[tstuefe]

Hi Martin,

looks simple enough. Make sure that all scripts and tests (also our internal? eg benchmarks) now pass -XX:+UnlockDiagnosticVMOptions.

Cheers, Thomas

[TheRealMDoerr]

Hi Thomas,

thanks for the review. I haven't found any tests which use one of these switches. Our tests have passed.

Best regards,
Martin

[RealLucy]

This is an overdue cleanup. Thanks for taking care. The changes look good to me. Reviewed.

[TheRealMDoerr]

/integrate

[openjdk]

@TheRealMDoerr This PR has not yet been marked as ready for integration.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253689: [s390] Use flag kind "diagnostic" for platform specific flags

Reviewed-by: stuefe, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

• a824289: 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
• 1d88172: 8253682: The AppletInitialFocusTest1.java is unstable
• 5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes
• 05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
• 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
• 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
• 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
• ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
• 092c227: 8252523: Add ASN.1 Formatter to work with test utility HexPrinter
• 06d8cf6: 8253812: Cleanup AbstractMemberWriter
• ... and 45 more: https://git.openjdk.java.net/jdk/compare/1ae6b533fbba433e64868aa3b6846041e3a91136...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

/integrate

[openjdk]

@TheRealMDoerr Since your change was applied there have been 55 commits pushed to the master branch:

• a824289: 8253690: [PPC64] Use flag kind "diagnostic" for platform specific flags
• 1d88172: 8253682: The AppletInitialFocusTest1.java is unstable
• 5dd9353: 8253636: C2: Adjust NodeClasses::_max_classes
• 05a764f: 8253883: Problem list jdk/test/lib/hexdump/ASN1Formatter on Windows
• 55c282b: 8253878: clean up nsk/share/jvmti/ArgumentHandler
• 776acfd: 8253880: clean up sun/hotspot/tools/ctw/Utils class
• 79d70f6: 8253869: sun/hotspot/whitebox/CPUInfoTest.java fails after JDK-8239090
• ca0e014: 8252003: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jvmti
• 092c227: 8252523: Add ASN.1 Formatter to work with test utility HexPrinter
• 06d8cf6: 8253812: Cleanup AbstractMemberWriter
• ... and 45 more: https://git.openjdk.java.net/jdk/compare/1ae6b533fbba433e64868aa3b6846041e3a91136...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7779ce9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.