Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240997: Remove more "hack" word in security codes #4148

Closed
wants to merge 1 commit into from

Conversation

jackh2000
Copy link
Contributor

@jackh2000 jackh2000 commented May 21, 2021

This change is part of a larger code cleanup effort and removes the term "hack" out of several files in the jdk.
JBS:


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8240997: Remove more "hack" word in security codes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4148/head:pull/4148
$ git checkout pull/4148

Update a local copy of the PR:
$ git checkout pull/4148
$ git pull https://git.openjdk.java.net/jdk pull/4148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4148

View PR using the GUI difftool:
$ git pr show -t 4148

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4148.diff

@bridgekeeper bridgekeeper bot added the oca label May 21, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 21, 2021

Hi @jackh2000, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user jackh2000" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@jackh2000
Copy link
Contributor Author

@jackh2000 jackh2000 commented May 21, 2021

/covered

@bridgekeeper bridgekeeper bot added the oca-verify label May 21, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 21, 2021

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

@openjdk openjdk bot commented May 21, 2021

@jackh2000 The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label May 21, 2021
@robilad
Copy link

@robilad robilad commented May 24, 2021

Hi,

Please send me an e-mail at Dalibor.Topic@oracle.com so that I can mark your account as verified.

@jackh2000 jackh2000 changed the title 8240997: Remove more hack word in security codes 8240997: Remove more "hack" word in security codes Jun 2, 2021
@bridgekeeper bridgekeeper bot removed oca oca-verify labels Jun 8, 2021
@openjdk openjdk bot added the rfr label Jun 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 8, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 8, 2021

@jackh2000 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8240997: Remove more "hack" word in security codes

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 295 new commits pushed to the master branch:

  • 1c3932f: 8264766: ClassCastException during template compilation (Variable cannot be cast to Param)
  • f6f82c3: 8266421: Deadlock in Sound System
  • bcaa2cb: 8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages
  • ae16052: 8268088: Clarify Method::clear_jmethod_ids() related comments in ClassLoaderData::~ClassLoaderData()
  • 5ad4a91: 8268127: Shenandoah: Heap size may be too small for region to align to large page size
  • 7a37816: 8264866: Remove unneeded WorkArounds.isAutomaticModule
  • 51e8201: 8267764: jpackage cannot handle window screensaver files when EXE renamed as SCR
  • f9b593d: 8266748: Move modifiers code to Signatures.java
  • 4dd0e7e: 8259806: Clean up terminology on the "All Classes" page
  • dc6c96b: 8263468: New page for "recent" new API
  • ... and 285 more: https://git.openjdk.java.net/jdk/compare/8e3549fc736539a45534dfe2b417170b5c991c7d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 8, 2021
@jackh2000
Copy link
Contributor Author

@jackh2000 jackh2000 commented Jun 9, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 9, 2021

@jackh2000
Your change (at version 344eb36) is now ready to be sponsored by a Committer.

@jnimeh
Copy link
Member

@jnimeh jnimeh commented Jun 9, 2021

/sponsor

@openjdk openjdk bot closed this Jun 9, 2021
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Jun 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 9, 2021

@jnimeh @jackh2000 Since your change was applied there have been 295 commits pushed to the master branch:

  • 1c3932f: 8264766: ClassCastException during template compilation (Variable cannot be cast to Param)
  • f6f82c3: 8266421: Deadlock in Sound System
  • bcaa2cb: 8264144: Add handling of "--about-url" CLI parameter for RPM/DEB packages
  • ae16052: 8268088: Clarify Method::clear_jmethod_ids() related comments in ClassLoaderData::~ClassLoaderData()
  • 5ad4a91: 8268127: Shenandoah: Heap size may be too small for region to align to large page size
  • 7a37816: 8264866: Remove unneeded WorkArounds.isAutomaticModule
  • 51e8201: 8267764: jpackage cannot handle window screensaver files when EXE renamed as SCR
  • f9b593d: 8266748: Move modifiers code to Signatures.java
  • 4dd0e7e: 8259806: Clean up terminology on the "All Classes" page
  • dc6c96b: 8263468: New page for "recent" new API
  • ... and 285 more: https://git.openjdk.java.net/jdk/compare/8e3549fc736539a45534dfe2b417170b5c991c7d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 58a59e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated security
4 participants