Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252937: Correct "no comment" warnings from javadoc in java.math package #415

Closed
wants to merge 1 commit into from

Conversation

@bplb
Copy link
Member

@bplb bplb commented Sep 29, 2020

Please review this simple change to clean up some warnings encountered when javadoc is run.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8252937: Correct "no comment" warnings from javadoc in java.math package

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/415/head:pull/415
$ git checkout pull/415

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2020

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Sep 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2020

Webrevs

@bplb bplb changed the title JDK-8252937: Correct "no comment" warnings from javadoc in java.math … JDK-8252937: Correct "no comment" warnings from javadoc in java.math package Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8252937: Correct "no comment" warnings from javadoc in java.math package

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 29, 2020
@bplb
Copy link
Member Author

@bplb bplb commented Sep 29, 2020

/issue add JDK-8252937

@openjdk openjdk bot changed the title JDK-8252937: Correct "no comment" warnings from javadoc in java.math package 8252937: Correct "no comment" warnings from javadoc in java.math package Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@bplb This issue is referenced in the PR title - it will now be updated.

@bplb
Copy link
Member Author

@bplb bplb commented Sep 29, 2020

/integrate

@openjdk openjdk bot closed this Sep 29, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@bplb Pushed as commit 5310d85.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 29, 2020
@bplb bplb deleted the JDK-8252937 branch Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants