New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267544: (test) rmi test NonLocalSkeleton fails if network has multiple adapters with the same address #4151
Conversation
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 31 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@RogerRiggs Since your change was applied there have been 31 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit d8e6e28. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Correct test code that creates a set of unique hostnames from an array of non-unique hostname.
Was using Set.of that throws if the elements are not unique.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4151/head:pull/4151
$ git checkout pull/4151
Update a local copy of the PR:
$ git checkout pull/4151
$ git pull https://git.openjdk.java.net/jdk pull/4151/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4151
View PR using the GUI difftool:
$ git pr show -t 4151
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4151.diff