Skip to content

JDK-8267575: Add new documentation group in HtmlStyle #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented May 22, 2021

Please review a relatively simple primarily-doc update for HtmlStyle.

The change is mostly grouping and commenting items.

Some existing comments were incorrect and have been updated.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267575: Add new documentation group in HtmlStyle

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4155/head:pull/4155
$ git checkout pull/4155

Update a local copy of the PR:
$ git checkout pull/4155
$ git pull https://git.openjdk.java.net/jdk pull/4155/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4155

View PR using the GUI difftool:
$ git pr show -t 4155

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4155.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 22, 2021
@openjdk
Copy link

openjdk bot commented May 22, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label May 22, 2021
@mlbridge
Copy link

mlbridge bot commented May 22, 2021

Webrevs

Copy link
Member

@hns hns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 25, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267575: Add new documentation group in HtmlStyle

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • a52c4ed: 8267110: Update java.util to use instanceof pattern variable
  • 0a03fc8: 8255674: SSLEngine class description is missing "case" in switch statement
  • d86f916: 8267066: New NSAccessibility peers should return they roles and subroles directly
  • 31d0f0d: 8248843: java in source-file mode suggests javac-only options
  • 2e8812d: 8265129: Add intrinsic support for JVM.getClassId
  • 123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
  • b4d4884: 8267126: javadoc should show "line and caret" for diagnostics.
  • 461a3fe: 8261478: InstanceKlass::set_classpath_index does not match comments
  • de27da7: 8267431: Rename InstanceKlass::has_old_class_version to can_be_verified_at_dumptime
  • c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
  • ... and 17 more: https://git.openjdk.java.net/jdk/compare/71e2fa25f73b0006a024edb59d79d837227ecd40...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 25, 2021
@jonathan-gibbons
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this May 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels May 25, 2021
@jonathan-gibbons jonathan-gibbons deleted the HtmlStyle-group branch May 25, 2021 14:54
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 25, 2021
@openjdk
Copy link

openjdk bot commented May 25, 2021

@jonathan-gibbons Since your change was applied there have been 31 commits pushed to the master branch:

  • 5a5b807: 8267633: Clarify documentation of (Doc)TreeScanner
  • 86a8f44: 8267317: Remove DeferredTypeCompleter
  • b403d39: 8267213: cpuinfo_segv is incorrectly triaged as execution protection violation on x86_32
  • 66b190e: 8267612: Declare package-private VarHandle.AccessMode/AccessType counts
  • a52c4ed: 8267110: Update java.util to use instanceof pattern variable
  • 0a03fc8: 8255674: SSLEngine class description is missing "case" in switch statement
  • d86f916: 8267066: New NSAccessibility peers should return they roles and subroles directly
  • 31d0f0d: 8248843: java in source-file mode suggests javac-only options
  • 2e8812d: 8265129: Add intrinsic support for JVM.getClassId
  • 123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
  • ... and 21 more: https://git.openjdk.java.net/jdk/compare/71e2fa25f73b0006a024edb59d79d837227ecd40...master

Your commit was automatically rebased without conflicts.

Pushed as commit cc687fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants