New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267578: Remove unnecessary preview checks #4157
Conversation
|
These checks need to remain to allow the Javac compiler to generate code for earlier releases. Please close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These checks need to remain to allow the Javac compiler to generate code for earlier releases. Please close.
Mailing list message from Jonathan Gibbons on compiler-dev: Guoxiong, To be clear, it is an overall requirement that in order to bootstrap-compile the JDK, we must be able to compile javac with the previously available release. Given the short interval between releases, this sometimes evaluates to a numerically 2-earlier release. For example, after we open up the repos for JDK 18 next month, JDK 17 will not be available until September, so we still need to compile javac with JDK 16 until then. -- Jon |
1 similar comment
Mailing list message from Jonathan Gibbons on compiler-dev: Guoxiong, To be clear, it is an overall requirement that in order to bootstrap-compile the JDK, we must be able to compile javac with the previously available release. Given the short interval between releases, this sometimes evaluates to a numerically 2-earlier release. For example, after we open up the repos for JDK 18 next month, JDK 17 will not be available until September, so we still need to compile javac with JDK 16 until then. -- Jon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@JimLaskey - please note that javac does not support preview features from previous versions (as per JEP 12). So once a feature is made final, it is safe to remove the preview checks, AFAIK, it just was not done for these few cases.
@lgxbslgx This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JimLaskey, @lahodaj) but any other Committer may sponsor as well.
|
@JimLaskey @jonathan-gibbons @lahodaj Thanks for your comments and reviews. This patch only cleans up the preview checks instead of something about releases. The similar cleanup codes are common when we implement the standard feature. Please see the following two cases.
We can consider that the codes of this patch were forgotten to cleanup during previous standard features. |
Apologies. I misread the nature of the change. |
/integrate |
/sponsor |
@lahodaj @lgxbslgx Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f453166. |
Hi all,
The following preview checks are unnecessary because they are standard features now.
Attr.java
JavacParser.java
Resolve.java
It is good to remove them.
Thanks for review.
Best Regards,
-- Guoxiong
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4157/head:pull/4157
$ git checkout pull/4157
Update a local copy of the PR:
$ git checkout pull/4157
$ git pull https://git.openjdk.java.net/jdk pull/4157/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4157
View PR using the GUI difftool:
$ git pr show -t 4157
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4157.diff