Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267584: The java.security.krb5.realm system property only needs to be defined once #4159

Closed
wants to merge 1 commit into from

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented May 23, 2021

A system property only needs to be put in a {@systemProperty} tag where it's first defined. For this one, it's

* {@systemProperty java.security.krb5.realm} and
.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267584: The java.security.krb5.realm system property only needs to be defined once

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4159/head:pull/4159
$ git checkout pull/4159

Update a local copy of the PR:
$ git checkout pull/4159
$ git pull https://git.openjdk.java.net/jdk pull/4159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4159

View PR using the GUI difftool:
$ git pr show -t 4159

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4159.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 23, 2021

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 23, 2021

@wangweij The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the security label May 23, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 23, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 24, 2021

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267584: The java.security.krb5.realm system property only needs to be defined once

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • f453166: 8267578: Remove unnecessary preview checks
  • 49f622c: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on
  • 54520fb: 8267580: The method JavacParser#peekToken is wrong when the first parameter is not zero
  • 3113910: 8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 24, 2021
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented May 24, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 24, 2021

@wangweij Since your change was applied there have been 7 commits pushed to the master branch:

  • f2d880c: 8266400: importkeystore fails to a password less pkcs12 keystore
  • f5562f1: 8258535: jvm.ClassReader should set the accessor to the corresponding record component
  • d8e6e28: 8267544: (test) rmi test NonLocalSkeleton fails if network has multiple adapters with the same address
  • f453166: 8267578: Remove unnecessary preview checks
  • 49f622c: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on
  • 54520fb: 8267580: The method JavacParser#peekToken is wrong when the first parameter is not zero
  • 3113910: 8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry()

Your commit was automatically rebased without conflicts.

Pushed as commit 838a007.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@wangweij wangweij deleted the 8267584 branch May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants