Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry() #4160

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented May 24, 2021

This is a trivial cleanup that was missed when "JDK-8252685 APIs that require JavaThread should take JavaThread arguments " was merged and integrated.

Thanks to @calvinccheung for spotting this.

Testing: tiers 1-3 (in progress)

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4160/head:pull/4160
$ git checkout pull/4160

Update a local copy of the PR:
$ git checkout pull/4160
$ git pull https://git.openjdk.java.net/jdk pull/4160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4160

View PR using the GUI difftool:
$ git pr show -t 4160

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4160.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 24, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 24, 2021
@dholmes-ora dholmes-ora changed the title @dholmes-ora 8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry() 8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry() May 24, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2021
@mlbridge
Copy link

mlbridge bot commented May 24, 2021

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. It looks good and trivial.

@openjdk
Copy link

openjdk bot commented May 24, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry()

Reviewed-by: ccheung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 4d26f22: 8264304: Create implementation for NSAccessibilityToolbar protocol peer
  • 6288a99: 8267404: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java failed with OutOfMemoryError
  • 71e2fa2: 8267531: [x86] Assembler::andb(Address,Register) encoding is incorrect
  • 4023646: 8266528: Optimize C2 VerifyIterativeGVN execution time
  • 2462316: 8261354: SIGSEGV at MethodIteratorHost
  • 72c9567: 8263486: Clean up MTLSurfaceDataBase.h
  • fe33343: 8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic
  • 8f10c5a: 8267190: Optimize Vector API test operations
  • 94cfeb9: 8256155: Allow multiple large page sizes to be used on Linux
  • ec8a809: 8267119: switch expressions lack support for deferred type-checking
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/1c7a1310d9985fd0ad05d901186eb0b6c0045d74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2021
@dholmes-ora
Copy link
Member Author

Thanks Calvin!

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2021
@openjdk
Copy link

openjdk bot commented May 24, 2021

@dholmes-ora Since your change was applied there have been 18 commits pushed to the master branch:

  • 4d26f22: 8264304: Create implementation for NSAccessibilityToolbar protocol peer
  • 6288a99: 8267404: vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java failed with OutOfMemoryError
  • 71e2fa2: 8267531: [x86] Assembler::andb(Address,Register) encoding is incorrect
  • 4023646: 8266528: Optimize C2 VerifyIterativeGVN execution time
  • 2462316: 8261354: SIGSEGV at MethodIteratorHost
  • 72c9567: 8263486: Clean up MTLSurfaceDataBase.h
  • fe33343: 8256304: should MonitorUsedDeflationThreshold be experimental or diagnostic
  • 8f10c5a: 8267190: Optimize Vector API test operations
  • 94cfeb9: 8256155: Allow multiple large page sizes to be used on Linux
  • ec8a809: 8267119: switch expressions lack support for deferred type-checking
  • ... and 8 more: https://git.openjdk.java.net/jdk/compare/1c7a1310d9985fd0ad05d901186eb0b6c0045d74...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3113910.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8267553 branch May 24, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants