New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267553: Extra JavaThread assignment in ClassLoader::create_class_path_entry() #4160
Conversation
|
@dholmes-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix. It looks good and trivial.
@dholmes-ora This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks Calvin! |
/integrate |
@dholmes-ora Since your change was applied there have been 18 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 3113910. |
This is a trivial cleanup that was missed when "JDK-8252685 APIs that require JavaThread should take JavaThread arguments " was merged and integrated.
Thanks to @calvinccheung for spotting this.
Testing: tiers 1-3 (in progress)
Thanks,
David
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4160/head:pull/4160
$ git checkout pull/4160
Update a local copy of the PR:
$ git checkout pull/4160
$ git pull https://git.openjdk.java.net/jdk pull/4160/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4160
View PR using the GUI difftool:
$ git pr show -t 4160
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4160.diff