8267066: New NSAccessibility peers should return they roles and subroles directly #4162

azuev-java · 2021-05-24T11:03:35Z

Made all implementing classes return their roles directly.
Change nullability attributes to the singular style across new classes.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8267066: New NSAccessibility peers should return they roles and subroles directly

Reviewers

Pankaj Bansal (@pankaj-bansal - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4162/head:pull/4162
$ git checkout pull/4162

Update a local copy of the PR:
$ git checkout pull/4162
$ git pull https://git.openjdk.java.net/jdk pull/4162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4162

View PR using the GUI difftool:
$ git pr show -t 4162

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4162.diff

…les directly Made all implementing classes return their roles directly. Change nullability attributes to the singular style across new classes.

bridgekeeper · 2021-05-24T11:04:22Z

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

azuev-java · 2021-05-24T11:04:53Z

/label awt

openjdk · 2021-05-24T11:07:24Z

@azuev-java
The awt label was successfully added.

mlbridge · 2021-05-24T11:10:22Z

Webrevs

01: Full - Incremental (3cd06156)
00: Full (c6a0cbc0)

pankaj-bansal · 2021-05-25T05:38:19Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CheckboxAccessibility.h

@@ -28,5 +28,6 @@
 @interface CheckboxAccessibility : ButtonAccessibility <NSAccessibilityCheckBox> {

 };
- (id)accessibilityValue;
+- (NSAccessibilityRole _Nonnull)accessibilityRole;
+- (id _Nonnull)accessibilityValue;


Looks like the value can be null. No?

Not here. The value here is a state of the checkbox - checked or not checked, unlike text components where value can be set to null, here value is being generated from the component state and can not be null.

pankaj-bansal · 2021-05-25T05:42:15Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/RadiobuttonAccessibility.h

@@ -28,5 +28,6 @@
 @interface RadiobuttonAccessibility : ButtonAccessibility <NSAccessibilityRadioButton> {

 };
- (id)accessibilityValue;
+- (NSAccessibilityRole _Nonnull)accessibilityRole;
+- (id _Nonnull)accessibilityValue;


Same as earlier. Can't this be null?

Same here, value represents the state of the control and can not be set to null.

pankaj-bansal · 2021-05-25T05:47:26Z

src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/StaticTextAccessibility.h

@@ -34,6 +34,7 @@
 @interface StaticTextAccessibility : CommonTextAccessibility<NSAccessibilityStaticText> {

 };
+- (NSAccessibilityRole _Nonnull)accessibilityRole;
 - (nullable NSString *)accessibilityAttributedStringForRange:(NSRange)range;
 - (nullable NSString *)accessibilityValue;


You missed these here in .h file

Yes. Fixed.

openjdk · 2021-05-25T06:41:01Z

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267066: New NSAccessibility peers should return they roles and subroles directly

Reviewed-by: pbansal

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

31d0f0d: 8248843: java in source-file mode suggests javac-only options
2e8812d: 8265129: Add intrinsic support for JVM.getClassId
123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
b4d4884: 8267126: javadoc should show "line and caret" for diagnostics.
461a3fe: 8261478: InstanceKlass::set_classpath_index does not match comments
de27da7: 8267431: Rename InstanceKlass::has_old_class_version to can_be_verified_at_dumptime
c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
ebc9357: 8267329: Modernize Javadoc code to use instanceof with pattern matching
209769b: 8267347: CDS record_linking_constraint asserts with unregistered class
... and 11 more: https://git.openjdk.java.net/jdk/compare/31139108c1ca9d355bd484d692830dfbc8317477...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

azuev-java · 2021-05-25T06:45:19Z

/integrate

openjdk · 2021-05-25T06:46:49Z

@azuev-java Since your change was applied there have been 21 commits pushed to the master branch:

31d0f0d: 8248843: java in source-file mode suggests javac-only options
2e8812d: 8265129: Add intrinsic support for JVM.getClassId
123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
b4d4884: 8267126: javadoc should show "line and caret" for diagnostics.
461a3fe: 8261478: InstanceKlass::set_classpath_index does not match comments
de27da7: 8267431: Rename InstanceKlass::has_old_class_version to can_be_verified_at_dumptime
c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
ebc9357: 8267329: Modernize Javadoc code to use instanceof with pattern matching
209769b: 8267347: CDS record_linking_constraint asserts with unregistered class
... and 11 more: https://git.openjdk.java.net/jdk/compare/31139108c1ca9d355bd484d692830dfbc8317477...master

Your commit was automatically rebased without conflicts.

Pushed as commit d86f916.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8267066: New NSAccessibility peers should return they roles and subro…

c6a0cbc

…les directly Made all implementing classes return their roles directly. Change nullability attributes to the singular style across new classes.

openjdk bot added rfr Pull request is ready for review awt client-libs-dev@openjdk.org labels May 24, 2021

pankaj-bansal reviewed May 25, 2021

View reviewed changes

Fixed old style nullability attributes in StaticTextAccessibility.h

3cd0615

pankaj-bansal approved these changes May 25, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 25, 2021

openjdk bot closed this May 25, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2021

azuev-java deleted the JDK-8267066 branch April 7, 2022 18:01

8267066: New NSAccessibility peers should return they roles and subroles directly #4162

8267066: New NSAccessibility peers should return they roles and subroles directly #4162

azuev-java commented May 24, 2021 •

edited by openjdk bot

bridgekeeper bot commented May 24, 2021

azuev-java commented May 24, 2021

openjdk bot commented May 24, 2021

mlbridge bot commented May 24, 2021 •

edited

pankaj-bansal May 25, 2021

azuev-java May 25, 2021

pankaj-bansal May 25, 2021

azuev-java May 25, 2021

pankaj-bansal May 25, 2021

azuev-java May 25, 2021

openjdk bot commented May 25, 2021 •

edited

azuev-java commented May 25, 2021

openjdk bot commented May 25, 2021

8267066: New NSAccessibility peers should return they roles and subroles directly #4162

8267066: New NSAccessibility peers should return they roles and subroles directly #4162

Conversation

azuev-java commented May 24, 2021 • edited by openjdk bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented May 24, 2021

azuev-java commented May 24, 2021

openjdk bot commented May 24, 2021

mlbridge bot commented May 24, 2021 • edited

Webrevs

pankaj-bansal May 25, 2021

Choose a reason for hiding this comment

azuev-java May 25, 2021

Choose a reason for hiding this comment

pankaj-bansal May 25, 2021

Choose a reason for hiding this comment

azuev-java May 25, 2021

Choose a reason for hiding this comment

pankaj-bansal May 25, 2021

Choose a reason for hiding this comment

azuev-java May 25, 2021

Choose a reason for hiding this comment

openjdk bot commented May 25, 2021 • edited

azuev-java commented May 25, 2021

openjdk bot commented May 25, 2021

azuev-java commented May 24, 2021 •

edited by openjdk bot

mlbridge bot commented May 24, 2021 •

edited

openjdk bot commented May 25, 2021 •

edited