Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8267611: Print more info when pointer_delta assert fails #4163

Closed
wants to merge 2 commits into from
Closed

8267611: Print more info when pointer_delta assert fails #4163

wants to merge 2 commits into from

Conversation

stefank
Copy link
Member

@stefank stefank commented May 24, 2021 •
edited by openjdk bot

We've seen a few new failures with the new pointer_delta assert. It would be nice if the assert printed the 'left' and 'right' pointer values.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267611: Print more info when pointer_delta assert fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4163/head:pull/4163
$ git checkout pull/4163

Update a local copy of the PR:
$ git checkout pull/4163
$ git pull https://git.openjdk.java.net/jdk pull/4163/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4163

View PR using the GUI difftool:
$ git pr show -t 4163

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4163.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2021

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2021
@openjdk
Copy link

openjdk bot commented May 24, 2021

@stefank The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label May 24, 2021
@mlbridge
Copy link

mlbridge bot commented May 24, 2021 •
edited

Webrevs

dholmes-ora
dholmes-ora approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks,
David

@openjdk
Copy link

openjdk bot commented May 24, 2021 •
edited

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267611: Print more info when pointer_delta assert fails

Reviewed-by: dholmes, jiefu, tschatzl, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

  • 9c346a1: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue
  • 45e0597: 8264302: Create implementation for Accessibility native peer for Splitpane java role
  • 4343997: 8267708: Remove references to com.sun.tools.javadoc.**
  • f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
  • bf8d4a8: 8267583: jmod fails on symlink to class file
  • 083416d: 8267130: Memory Overflow in Disassembler::load_library
  • 9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
  • 0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
  • b33b8bc: 8267750: Incomplete fix for JDK-8267683
  • ac36b7d: 8267452: Delegate forEachRemaining in Spliterators.iterator()
  • ... and 37 more: https://git.openjdk.java.net/jdk/compare/31139108c1ca9d355bd484d692830dfbc8317477...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2021
@stefank
Copy link
Member Author

stefank commented May 25, 2021

Thanks for reviewing!

kimbarrett
kimbarrett suggested changes May 26, 2021
View reviewed changes
src/hotspot/share/utilities/globalDefinitions.hpp Outdated
@@ -151,6 +151,15 @@ class oopDesc;
#define INTX_FORMAT_W(width) "%" #width PRIdPTR
#define UINTX_FORMAT_W(width) "%" #width PRIuPTR

// Convert pointer to intptr_t, for use in printing pointers.
inline intptr_t p2i(const void* p) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the const void* overload is needed, given the presence of the const volatile void* overload.

kimbarrett
kimbarrett approved these changes May 26, 2021
View reviewed changes
Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stefank
Copy link
Member Author

stefank commented May 26, 2021

Thanks for the reviews!
/integrate

@openjdk openjdk bot closed this May 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2021
@openjdk
Copy link

openjdk bot commented May 26, 2021

@stefank Since your change was applied there have been 48 commits pushed to the master branch:

  • a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current
  • 9c346a1: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue
  • 45e0597: 8264302: Create implementation for Accessibility native peer for Splitpane java role
  • 4343997: 8267708: Remove references to com.sun.tools.javadoc.**
  • f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
  • bf8d4a8: 8267583: jmod fails on symlink to class file
  • 083416d: 8267130: Memory Overflow in Disassembler::load_library
  • 9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
  • 0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
  • b33b8bc: 8267750: Incomplete fix for JDK-8267683
  • ... and 38 more: https://git.openjdk.java.net/jdk/compare/31139108c1ca9d355bd484d692830dfbc8317477...master

Your commit was automatically rebased without conflicts.

Pushed as commit de91643.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stefank stefank deleted the 8267611_pointer_delta_assert_msg branch June 2, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamonFool DamonFool DamonFool approved these changes

@tschatzl tschatzl tschatzl approved these changes

@dholmes-ora dholmes-ora dholmes-ora approved these changes

@kimbarrett kimbarrett kimbarrett approved these changes

Assignees
No one assigned
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
5 participants
@stefank @DamonFool @tschatzl @dholmes-ora @kimbarrett