Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267612; Declare package-private VarHandle.AccessMode/AccessType counts #4164

Closed
wants to merge 2 commits into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented May 24, 2021

Slightly reduce VarHandle startup overhead by introducing package-private COUNT constants for two enums


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267612: Declare package-private VarHandle.AccessMode/AccessType counts

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4164/head:pull/4164
$ git checkout pull/4164

Update a local copy of the PR:
$ git checkout pull/4164
$ git pull https://git.openjdk.java.net/jdk pull/4164/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4164

View PR using the GUI difftool:
$ git pr show -t 4164

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4164.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 24, 2021
@openjdk
Copy link

openjdk bot commented May 24, 2021

@cl4es The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 24, 2021
@mlbridge
Copy link

mlbridge bot commented May 24, 2021

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cl4es cl4es changed the title 8267612: Declare package-private VarHandle.AccessMode/-Type counts 8267612; Declare package-private VarHandle.AccessMode/AccessType counts May 24, 2021
@openjdk
Copy link

openjdk bot commented May 24, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267612: Declare package-private VarHandle.AccessMode/AccessType counts

Reviewed-by: mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
  • f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
  • ebc9357: 8267329: Modernize Javadoc code to use instanceof with pattern matching
  • 209769b: 8267347: CDS record_linking_constraint asserts with unregistered class
  • a5467ae: 8267423: Fix copyrights in jpackage tests
  • bb085f6: 8265362: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
  • 640a2af: 8267184: Add -Djava.security.manager=allow to tests calling System.setSecurityManager
  • f04db5f: 8224158: assertion related to NPE at DynamicCallSiteDesc::withArgs should be reworded
  • 838a007: 8267584: The java.security.krb5.realm system property only needs to be defined once
  • f2d880c: 8266400: importkeystore fails to a password less pkcs12 keystore
  • ... and 52 more: https://git.openjdk.java.net/jdk/compare/9760dba71c07cf7b0df16590b3e84e23ad587621...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 24, 2021
@cl4es
Copy link
Member Author

cl4es commented May 25, 2021

Thanks Mandy!

/integrate

@openjdk openjdk bot closed this May 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2021
@openjdk
Copy link

openjdk bot commented May 25, 2021

@cl4es Since your change was applied there have been 71 commits pushed to the master branch:

  • a52c4ed: 8267110: Update java.util to use instanceof pattern variable
  • 0a03fc8: 8255674: SSLEngine class description is missing "case" in switch statement
  • d86f916: 8267066: New NSAccessibility peers should return they roles and subroles directly
  • 31d0f0d: 8248843: java in source-file mode suggests javac-only options
  • 2e8812d: 8265129: Add intrinsic support for JVM.getClassId
  • 123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
  • b4d4884: 8267126: javadoc should show "line and caret" for diagnostics.
  • 461a3fe: 8261478: InstanceKlass::set_classpath_index does not match comments
  • de27da7: 8267431: Rename InstanceKlass::has_old_class_version to can_be_verified_at_dumptime
  • c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
  • ... and 61 more: https://git.openjdk.java.net/jdk/compare/9760dba71c07cf7b0df16590b3e84e23ad587621...master

Your commit was automatically rebased without conflicts.

Pushed as commit 66b190e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cl4es cl4es deleted the vhcount branch May 25, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants