8267614: Outline VarHandleGuards exact behavior checks

[cl4es]

Extract some common behavior checks from the generated VarHandleGuards code to a package-private VarHandle method. This reduces the code size (-5.2kb lib/modules) and slightly improves startup, while being performance neutral on microbenchmarks.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267614: Outline VarHandleGuards exact behavior checks

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer)
• Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4165/head:pull/4165
$ git checkout pull/4165

Update a local copy of the PR:
$ git checkout pull/4165
$ git pull https://git.openjdk.java.net/jdk pull/4165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4165

View PR using the GUI difftool:
$ git pr show -t 4165

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4165.diff

[bridgekeeper]

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cl4es The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (875e71ad)

[PaulSandoz]

Looks good.

[openjdk]

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267614: Outline VarHandleGuards exact behavior checks

Reviewed-by: psandoz, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• bb085f6: 8265362: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
• 640a2af: 8267184: Add -Djava.security.manager=allow to tests calling System.setSecurityManager
• f04db5f: 8224158: assertion related to NPE at DynamicCallSiteDesc::withArgs should be reworded
• 838a007: 8267584: The java.security.krb5.realm system property only needs to be defined once
• f2d880c: 8266400: importkeystore fails to a password less pkcs12 keystore
• f5562f1: 8258535: jvm.ClassReader should set the accessor to the corresponding record component
• d8e6e28: 8267544: (test) rmi test NonLocalSkeleton fails if network has multiple adapters with the same address
• f453166: 8267578: Remove unnecessary preview checks
• 49f622c: 8208747: [a11y] [macos] In Optionpane Demo, inside ComponentDialog Example, unable to navigate to all items, with VO on
• 54520fb: 8267580: The method JavacParser#peekToken is wrong when the first parameter is not zero
• ... and 47 more: https://git.openjdk.java.net/jdk/compare/9760dba71c07cf7b0df16590b3e84e23ad587621...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[cl4es]

Paul, Mandy, thanks for reviewing

/integrate

[openjdk]

@cl4es Since your change was applied there have been 61 commits pushed to the master branch:

• f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
• ebc9357: 8267329: Modernize Javadoc code to use instanceof with pattern matching
• 209769b: 8267347: CDS record_linking_constraint asserts with unregistered class
• a5467ae: 8267423: Fix copyrights in jpackage tests
• bb085f6: 8265362: java/net/Socket/UdpSocket.java fails with "java.net.BindException: Address already in use" (macos-aarch64)
• 640a2af: 8267184: Add -Djava.security.manager=allow to tests calling System.setSecurityManager
• f04db5f: 8224158: assertion related to NPE at DynamicCallSiteDesc::withArgs should be reworded
• 838a007: 8267584: The java.security.krb5.realm system property only needs to be defined once
• f2d880c: 8266400: importkeystore fails to a password less pkcs12 keystore
• f5562f1: 8258535: jvm.ClassReader should set the accessor to the corresponding record component
• ... and 51 more: https://git.openjdk.java.net/jdk/compare/9760dba71c07cf7b0df16590b3e84e23ad587621...master

Your commit was automatically rebased without conflicts.

Pushed as commit c519ba2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.