8267651: runtime/handshake/HandshakeTimeoutTest.java times out when dumping core

[dholmes-ora]

Please review this trivial test fix to add -XX:-CreateCoredumpOnCrash to the exec'd VM that we expect to crash with SIGILL. If the core dump is generated it can take a long time on macos and cause the whole test to timeout.

Testing: ran 50x on macos-x64, plus local linux-x64

Thanks,
David

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267651: runtime/handshake/HandshakeTimeoutTest.java times out when dumping core

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4177/head:pull/4177
$ git checkout pull/4177

Update a local copy of the PR:
$ git checkout pull/4177
$ git pull https://git.openjdk.java.net/jdk pull/4177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4177

View PR using the GUI difftool:
$ git pr show -t 4177

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4177.diff

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (58391814)

[dcubed-ojdk]

Thumbs up!

I agree that this is a trivial fix.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267651: runtime/handshake/HandshakeTimeoutTest.java times out when dumping core

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• 86a8f44: 8267317: Remove DeferredTypeCompleter
• b403d39: 8267213: cpuinfo_segv is incorrectly triaged as execution protection violation on x86_32
• 66b190e: 8267612: Declare package-private VarHandle.AccessMode/AccessType counts
• a52c4ed: 8267110: Update java.util to use instanceof pattern variable
• 0a03fc8: 8255674: SSLEngine class description is missing "case" in switch statement
• d86f916: 8267066: New NSAccessibility peers should return they roles and subroles directly
• 31d0f0d: 8248843: java in source-file mode suggests javac-only options
• 2e8812d: 8265129: Add intrinsic support for JVM.getClassId
• 123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
• b4d4884: 8267126: javadoc should show "line and caret" for diagnostics.
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/31139108c1ca9d355bd484d692830dfbc8317477...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Thanks Dan!

[dholmes-ora]

/integrate

[openjdk]

@dholmes-ora Since your change was applied there have been 36 commits pushed to the master branch:

• a98e476: 8267311: vmTestbase/gc/gctests/StringInternGC/StringInternGC.java eventually OOMEs
• 5aa45f2: 8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package"
• c20ca42: 8267691: Change table to obsolete CriticalJNINatives in JDK 18, not 17
• e751b7b: 8267683: rfc7301Grease8F value not displayed correctly in SSLParameters javadoc
• 0b77359: 8224243: Add implSpec's to AccessibleObject and seal Executable
• 594d454: 8267574: Dead code in HtmlStyle/HtmlDocletWriter
• 2ef2450: 8263445: Duplicate key compiler.err.expected.module in compiler.properties
• cc687fd: 8267575: Add new documentation group in HtmlStyle
• 5a5b807: 8267633: Clarify documentation of (Doc)TreeScanner
• 86a8f44: 8267317: Remove DeferredTypeCompleter
• ... and 26 more: https://git.openjdk.java.net/jdk/compare/31139108c1ca9d355bd484d692830dfbc8317477...master

Your commit was automatically rebased without conflicts.

Pushed as commit d0d2ddc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.