Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267657: Add missing PrintC1Statistics before incrementing counters #4178

Closed
wants to merge 1 commit into from

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented May 25, 2021

Trivial change to add missing PrintC1Statistics before incrementing counters.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267657: Add missing PrintC1Statistics before incrementing counters

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4178/head:pull/4178
$ git checkout pull/4178

Update a local copy of the PR:
$ git checkout pull/4178
$ git pull https://git.openjdk.java.net/jdk pull/4178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4178

View PR using the GUI difftool:
$ git pr show -t 4178

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4178.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 25, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@kelthuzadx The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the hotspot label May 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 25, 2021

Webrevs

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented May 25, 2021

/label add hotspot-compiler

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@kelthuzadx
The hotspot-compiler label was successfully added.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jun 7, 2021

PING:Can I have a review of this trivial change?Thanks.

Loading

Copy link
Contributor

@veresov veresov left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267657: Add missing PrintC1Statistics before incrementing counters

Reviewed-by: iveresov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 443 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jun 21, 2021
@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jun 22, 2021

Thank you Igor for the review!

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Jun 22, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

Going to push as commit 2e639dd.
Since your change was applied there have been 452 commits pushed to the master branch:

  • 1f0ea7c: 8268857: Merge VM_PrintJNI and VM_PrintThreads and remove the unused field 'is_deadlock' of DeadlockCycle
  • 1a81815: 8269077: TestSystemGC uses "require vm.gc.G1" for large pages subtest
  • 0458113: Merge
  • d3ad8cd: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • f25e719: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails
  • 22ebd19: 8268362: [REDO] C2 crash when compile negative Arrays.copyOf length after loop
  • f8df953: 8268702: JFR diagnostic commands lack argument descriptors when viewed using Platform MBean Server
  • c294ae4: 8267042: bug in monitor locking/unlocking on ARM32 C1 due to uninitialized BasicObjectLock::_displaced_header
  • b358b54: 8269063: Build failure due to VerifyReceiverTypes was not declared after JDK-8268405
  • cd20c01: 8268458: Add verification type for evacuation failures
  • ... and 442 more: https://git.openjdk.java.net/jdk/compare/4d26f22b9adcf7cecca5316348ef670ac2dbc365...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Jun 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@kelthuzadx Pushed as commit 2e639dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kelthuzadx kelthuzadx deleted the printc1statistics branch Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants