Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255674: SSLEngine class description is missing "case" in switch statement #4180

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented May 25, 2021

Can I please get a review for this trivial fix in the code sample in javadoc comment of javax.net.ssl.SSLEngine class?

I've run make docs-image locally and the generated javadoc after this change looks fine.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8255674: SSLEngine class description is missing "case" in switch statement

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4180/head:pull/4180
$ git checkout pull/4180

Update a local copy of the PR:
$ git checkout pull/4180
$ git pull https://git.openjdk.java.net/jdk pull/4180/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4180

View PR using the GUI difftool:
$ git pr show -t 4180

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4180.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 25, 2021

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@jaikiran The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security net labels May 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 25, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8255674: SSLEngine class description is missing "case" in switch statement

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 31d0f0d: 8248843: java in source-file mode suggests javac-only options
  • 2e8812d: 8265129: Add intrinsic support for JVM.getClassId
  • 123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
  • b4d4884: 8267126: javadoc should show "line and caret" for diagnostics.
  • 461a3fe: 8261478: InstanceKlass::set_classpath_index does not match comments
  • de27da7: 8267431: Rename InstanceKlass::has_old_class_version to can_be_verified_at_dumptime
  • c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
  • f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
  • ebc9357: 8267329: Modernize Javadoc code to use instanceof with pattern matching
  • 209769b: 8267347: CDS record_linking_constraint asserts with unregistered class
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/ee2651b9e5a9ab468b4be73d43b8f643e9e92042...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 25, 2021
@jaikiran
Copy link
Member Author

@jaikiran jaikiran commented May 25, 2021

Thank you Xuelei for the review.

@jaikiran
Copy link
Member Author

@jaikiran jaikiran commented May 25, 2021

/integrate

@openjdk openjdk bot closed this May 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@jaikiran Since your change was applied there have been 34 commits pushed to the master branch:

  • d86f916: 8267066: New NSAccessibility peers should return they roles and subroles directly
  • 31d0f0d: 8248843: java in source-file mode suggests javac-only options
  • 2e8812d: 8265129: Add intrinsic support for JVM.getClassId
  • 123cdd1: 8264973: AArch64: Optimize vector max/min/add reduction of two integers with NEON pairwise instructions
  • b4d4884: 8267126: javadoc should show "line and caret" for diagnostics.
  • 461a3fe: 8261478: InstanceKlass::set_classpath_index does not match comments
  • de27da7: 8267431: Rename InstanceKlass::has_old_class_version to can_be_verified_at_dumptime
  • c519ba2: 8267614: Outline VarHandleGuards exact behavior checks
  • f690959: 8267446: Taskqueue code fails with assert(bottom_relaxed() == age_top_relaxed()) failed: not empty
  • ebc9357: 8267329: Modernize Javadoc code to use instanceof with pattern matching
  • ... and 24 more: https://git.openjdk.java.net/jdk/compare/ee2651b9e5a9ab468b4be73d43b8f643e9e92042...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0a03fc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the 8255674 branch May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net security
2 participants