Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264302: Create implementation for Accessibility native peer for Splitpane java role #4181

Closed
wants to merge 4 commits into from

Conversation

@pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented May 25, 2021

Create implementation for Accessibility native peer for Splitpane java role. I have tested it using the SwingSet2 and splitpane demo from https://docs.oracle.com/javase/tutorial/uiswing/examples/components/index.html#SplitPaneDemo.
The do not see any inconsistency in Vo behaviour before and after the changes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264302: Create implementation for Accessibility native peer for Splitpane java role

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4181/head:pull/4181
$ git checkout pull/4181

Update a local copy of the PR:
$ git checkout pull/4181
$ git pull https://git.openjdk.java.net/jdk pull/4181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4181

View PR using the GUI difftool:
$ git pr show -t 4181

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4181.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 25, 2021

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@pankaj-bansal The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label May 25, 2021
@pankaj-bansal pankaj-bansal marked this pull request as ready for review May 25, 2021
@openjdk openjdk bot added the rfr label May 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 25, 2021

Webrevs

#import "SplitpaneAccessibility.h"

/*
* Implementation of the accessibility peer for the ScrollBar role
Copy link
Member

@azuev-java azuev-java May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ScrollBar? I think you meant something else.

Copy link
Author

@pankaj-bansal pankaj-bansal May 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264302: Create implementation for Accessibility native peer for Splitpane java role

Reviewed-by: kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 4343997: 8267708: Remove references to com.sun.tools.javadoc.**
  • f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
  • bf8d4a8: 8267583: jmod fails on symlink to class file
  • 083416d: 8267130: Memory Overflow in Disassembler::load_library
  • 9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
  • 0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
  • b33b8bc: 8267750: Incomplete fix for JDK-8267683
  • ac36b7d: 8267452: Delegate forEachRemaining in Spliterators.iterator()
  • d0d2ddc: 8267651: runtime/handshake/HandshakeTimeoutTest.java times out when dumping core
  • a98e476: 8267311: vmTestbase/gc/gctests/StringInternGC/StringInternGC.java eventually OOMEs
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/d86f91642d7dcf829b8093ebed336d4386bff67a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 26, 2021
@pankaj-bansal
Copy link
Author

@pankaj-bansal pankaj-bansal commented May 26, 2021

/integrate

@openjdk openjdk bot closed this May 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@pankaj-bansal Since your change was applied there have been 23 commits pushed to the master branch:

  • 4343997: 8267708: Remove references to com.sun.tools.javadoc.**
  • f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
  • bf8d4a8: 8267583: jmod fails on symlink to class file
  • 083416d: 8267130: Memory Overflow in Disassembler::load_library
  • 9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
  • 0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
  • b33b8bc: 8267750: Incomplete fix for JDK-8267683
  • ac36b7d: 8267452: Delegate forEachRemaining in Spliterators.iterator()
  • d0d2ddc: 8267651: runtime/handshake/HandshakeTimeoutTest.java times out when dumping core
  • a98e476: 8267311: vmTestbase/gc/gctests/StringInternGC/StringInternGC.java eventually OOMEs
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/d86f91642d7dcf829b8093ebed336d4386bff67a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 45e0597.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pankaj-bansal pankaj-bansal deleted the JDK-8264302 branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants