New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263445: Duplicate key compiler.err.expected.module in compiler.properties #4186
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@asotona This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/integrate |
@asotona Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 2ef2450. |
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties contains duplicate key:
compiler.err.expected.module
This fix removes the first occurrence of the key to remove the duplicity and keep the actual content of the property.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4186/head:pull/4186
$ git checkout pull/4186
Update a local copy of the PR:
$ git checkout pull/4186
$ git pull https://git.openjdk.java.net/jdk pull/4186/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4186
View PR using the GUI difftool:
$ git pr show -t 4186
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4186.diff