Skip to content

Conversation

@jamsheedcm
Copy link
Member

@jamsheedcm jamsheedcm commented May 25, 2021

Issue is similar to https://bugs.openjdk.java.net/browse/JDK-8261730
but happens at next https://github.com/jamsheedcm/jdk/blob/master/src/hotspot/share/opto/gcm.cpp#L830

Request for review


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265132: C2 compilation fails with assert "missing precedence edge"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4189/head:pull/4189
$ git checkout pull/4189

Update a local copy of the PR:
$ git checkout pull/4189
$ git pull https://git.openjdk.java.net/jdk pull/4189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4189

View PR using the GUI difftool:
$ git pr show -t 4189

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4189.diff

@jamsheedcm jamsheedcm changed the title 8265132: C2 compilation fails with assert "missing precedence edge" DRAFT: 8265132: C2 compilation fails with assert "missing precedence edge" May 25, 2021
@jamsheedcm jamsheedcm marked this pull request as draft May 25, 2021 16:04
@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2021

👋 Welcome back jcm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 25, 2021

⚠️ @jamsheedcm This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk
Copy link

openjdk bot commented May 25, 2021

@jamsheedcm The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 25, 2021
@jamsheedcm jamsheedcm changed the title DRAFT: 8265132: C2 compilation fails with assert "missing precedence edge" 8265132: C2 compilation fails with assert "missing precedence edge" May 25, 2021
@jamsheedcm jamsheedcm marked this pull request as ready for review May 25, 2021 18:25
@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2021
@mlbridge
Copy link

mlbridge bot commented May 25, 2021

Webrevs

@jamsheedcm
Copy link
Member Author

/label hotspot-compiler

@openjdk
Copy link

openjdk bot commented May 25, 2021

@jamsheedcm The hotspot-compiler label was already applied.

@jamsheedcm jamsheedcm marked this pull request as draft May 25, 2021 23:38
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 25, 2021
@jamsheedcm jamsheedcm marked this pull request as ready for review May 25, 2021 23:39
@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2021
@jamsheedcm
Copy link
Member Author

/label rfr

@openjdk
Copy link

openjdk bot commented May 26, 2021

@jamsheedcm The label rfr is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

@jamsheedcm jamsheedcm marked this pull request as draft May 26, 2021 03:40
@jamsheedcm jamsheedcm marked this pull request as ready for review May 26, 2021 03:40
@openjdk openjdk bot added rfr Pull request is ready for review and removed rfr Pull request is ready for review labels May 26, 2021
@jamsheedcm jamsheedcm changed the title 8265132: C2 compilation fails with assert "missing precedence edge" DRAFT: 8265132: C2 compilation fails with assert "missing precedence edge" May 26, 2021
@jamsheedcm jamsheedcm changed the title DRAFT: 8265132: C2 compilation fails with assert "missing precedence edge" 8265132: C2 compilation fails with assert "missing precedence edge" May 26, 2021
@jamsheedcm jamsheedcm closed this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant