8253829: Wrong length compared in SSPI bridge

[wangweij]

For two principals to be the same, they are either all "user@R", or one is "user" and the other is "user@R". The check here wants to fail early if the length are different. "l" is the whole length and "r" is the length of the name (without realm). The comparison should be reflective but there is a typo.

For example, for "user@R" and "user", l1 = 6, l2 = 4, r1 = 4, r2 = 4, the check will succeed and the names are treated as different. This is not the expected behavior.

No regression test because we don't support SSPI testing in the OpenJDK repo now.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8253829: Wrong length compared in SSPI bridge

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/419/head:pull/419
$ git checkout pull/419

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (7be88a2)

[valeriepeng]

Looks fine.

[wangweij]

/integrate

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253829: Wrong length compared in SSPI bridge

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

• 9e453d9: 8239090: Improve CPU feature support in VM_Version
• 8f7c9a7: 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi
• 8cf8e46: 8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration
• 8b3d676: 8238737: remove DeoptimizeAllClassesRate from CTW library
• 709cfe5: 8253815: Remove unused HeapRegionManager::_num_committed from SA
• f80a606: 8253375: OSX build fails with Xcode 12.0 (12A7209)
• 04775f1: 8253768: Deleting unused pipe_class definitions in adl-file (x86_64.ad).
• dc3a0f5: 8253183: Fragile memory barrier selection for some weak memory model platforms
• 8331e63: 8253778: ShenandoahSafepoint::is_at_shenandoah_safepoint should not access VMThread state from other threads
• 4c65365: 8253792: javax.swing.text.GapContent documentation typos
• ... and 88 more: https://git.openjdk.java.net/jdk/compare/b8ea80af33ecc9d4ccfa3c3dc366e1a88c3607b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wangweij Since your change was applied there have been 98 commits pushed to the master branch:

• 9e453d9: 8239090: Improve CPU feature support in VM_Version
• 8f7c9a7: 8252001: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdi
• 8cf8e46: 8253700: spurious "extends Throwable" at end of Optional.orElseThrow method declaration
• 8b3d676: 8238737: remove DeoptimizeAllClassesRate from CTW library
• 709cfe5: 8253815: Remove unused HeapRegionManager::_num_committed from SA
• f80a606: 8253375: OSX build fails with Xcode 12.0 (12A7209)
• 04775f1: 8253768: Deleting unused pipe_class definitions in adl-file (x86_64.ad).
• dc3a0f5: 8253183: Fragile memory barrier selection for some weak memory model platforms
• 8331e63: 8253778: ShenandoahSafepoint::is_at_shenandoah_safepoint should not access VMThread state from other threads
• 4c65365: 8253792: javax.swing.text.GapContent documentation typos
• ... and 88 more: https://git.openjdk.java.net/jdk/compare/b8ea80af33ecc9d4ccfa3c3dc366e1a88c3607b4...master

Your commit was automatically rebased without conflicts.

Pushed as commit e5ba020.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.