Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar #4191

wants to merge 1 commit into from


Copy link

@naotoj naotoj commented May 25, 2021

Please review the fix. The issue was informed yesterday by @amaembo that it offends some code analysis tools.
Although the fix is to change the condition error, it turned out that JapaneseImperialCalendar.roll() did not work for WEEK_OF_MONTH and DAY_OF_MONTH. There was an inherent issue where GregorianCalendar does not follow the roll() spec, i.e., "The MONTH must not change when the WEEK_OF_MONTH is rolled." during the Julian/Gregorian transition. JDK-6191841 seems to have tried to fix it but it was closed as Future Project...
So I simply fixed the roll() issue in JapaneseImperialCalendar to follow the spec here, which seems to be the intent of the original author.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar



Using git

Checkout this PR locally:
$ git fetch pull/4191/head:pull/4191
$ git checkout pull/4191

Update a local copy of the PR:
$ git checkout pull/4191
$ git pull pull/4191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4191

View PR using the GUI difftool:
$ git pr show -t 4191

Using diff file

Download this PR as a diff file:

Copy link

bridgekeeper bot commented May 25, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2021
Copy link

openjdk bot commented May 25, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs i18n labels May 25, 2021
Copy link

mlbridge bot commented May 25, 2021


Copy link

openjdk bot commented May 25, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file for details.

After integration, the commit message for the final commit will be:

8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar

Reviewed-by: joehw, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • de91643: 8267611: Print more info when pointer_delta assert fails
  • a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current
  • 9c346a1: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue
  • 45e0597: 8264302: Create implementation for Accessibility native peer for Splitpane java role
  • 4343997: 8267708: Remove references to**
  • f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
  • bf8d4a8: 8267583: jmod fails on symlink to class file
  • 083416d: 8267130: Memory Overflow in Disassembler::load_library
  • 9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
  • 0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
  • ... and 30 more:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 25, 2021
Copy link
Member Author

naotoj commented May 27, 2021


@openjdk openjdk bot closed this May 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2021
Copy link

openjdk bot commented May 27, 2021

@naotoj Since your change was applied there have been 53 commits pushed to the master branch:

  • ec65cf8: 8240347: remove undocumented options from jlink --help message
  • 3623abb: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles
  • 85f6165: 8267817: [TEST] Remove unnecessary init in test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench:setup
  • 7278f56: 8267800: Remove the '_dirty' set in BCEscapeAnalyzer
  • bfa46f0: 8252476: as_Worker_thread() doesn't check what it intends
  • 37bc4e2: 8263635: Add --servername option to jhsdb debugd
  • 6ffa3e6: 8267754: cds/appcds/loaderConstraints/ fails on x86_32 due to customized class loader is not supported
  • 1899f02: 8267805: Add UseVtableBasedCHA to the list of JVM flags known to jtreg
  • 0fc7c8d: 8267751: (test) jtreg.SkippedException has no serial VersionUID
  • a859d87: 8267721: Enable sun/security/pkcs11 tests for Amazon Linux 2 AArch64
  • ... and 43 more:

Your commit was automatically rebased without conflicts.

Pushed as commit bea4109.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@naotoj naotoj deleted the JDK-8187649 branch June 2, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
core-libs i18n integrated Pull request has been integrated
3 participants