Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267683: rfc7301Grease8F value not displayed correctly in SSLParameters javadoc #4193

Closed
wants to merge 2 commits into from
Closed

8267683: rfc7301Grease8F value not displayed correctly in SSLParameters javadoc #4193

wants to merge 2 commits into from

Conversation

bradfordwetmore
Copy link
Contributor

@bradfordwetmore bradfordwetmore commented May 25, 2021

Simple typo fix. Somehow the trailing "u" got omitted, so the code won't parse when fed into the compiler.

Resulting javadoc output now compiles.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267683: rfc7301Grease8F value not displayed correctly in SSLParameters javadoc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4193/head:pull/4193
$ git checkout pull/4193

Update a local copy of the PR:
$ git checkout pull/4193
$ git pull https://git.openjdk.java.net/jdk pull/4193/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4193

View PR using the GUI difftool:
$ git pr show -t 4193

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4193.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 25, 2021

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@bradfordwetmore The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security net labels May 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 25, 2021

Webrevs

Copy link
Contributor

@coffeys coffeys left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267683: rfc7301Grease8F value not displayed correctly in SSLParameters javadoc

Reviewed-by: coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

  • 0b77359: 8224243: Add implSpec's to AccessibleObject and seal Executable
  • 594d454: 8267574: Dead code in HtmlStyle/HtmlDocletWriter
  • 2ef2450: 8263445: Duplicate key compiler.err.expected.module in compiler.properties
  • cc687fd: 8267575: Add new documentation group in HtmlStyle
  • 5a5b807: 8267633: Clarify documentation of (Doc)TreeScanner
  • 86a8f44: 8267317: Remove DeferredTypeCompleter
  • b403d39: 8267213: cpuinfo_segv is incorrectly triaged as execution protection violation on x86_32
  • 66b190e: 8267612: Declare package-private VarHandle.AccessMode/AccessType counts
  • a52c4ed: 8267110: Update java.util to use instanceof pattern variable
  • 0a03fc8: 8255674: SSLEngine class description is missing "case" in switch statement
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/1c7a1310d9985fd0ad05d901186eb0b6c0045d74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 25, 2021
@bradfordwetmore
Copy link
Contributor Author

@bradfordwetmore bradfordwetmore commented May 25, 2021

/integrate

@openjdk openjdk bot closed this May 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 25, 2021

@bradfordwetmore Since your change was applied there have been 51 commits pushed to the master branch:

  • 0b77359: 8224243: Add implSpec's to AccessibleObject and seal Executable
  • 594d454: 8267574: Dead code in HtmlStyle/HtmlDocletWriter
  • 2ef2450: 8263445: Duplicate key compiler.err.expected.module in compiler.properties
  • cc687fd: 8267575: Add new documentation group in HtmlStyle
  • 5a5b807: 8267633: Clarify documentation of (Doc)TreeScanner
  • 86a8f44: 8267317: Remove DeferredTypeCompleter
  • b403d39: 8267213: cpuinfo_segv is incorrectly triaged as execution protection violation on x86_32
  • 66b190e: 8267612: Declare package-private VarHandle.AccessMode/AccessType counts
  • a52c4ed: 8267110: Update java.util to use instanceof pattern variable
  • 0a03fc8: 8255674: SSLEngine class description is missing "case" in switch statement
  • ... and 41 more: https://git.openjdk.java.net/jdk/compare/1c7a1310d9985fd0ad05d901186eb0b6c0045d74...master

Your commit was automatically rebased without conflicts.

Pushed as commit e751b7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bradfordwetmore bradfordwetmore deleted the JDK-8267683 branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net security
2 participants