Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267123: Remove RMI Activation #4194

Conversation

stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented May 25, 2021

This is the implementation of JEP 407.

This is a fairly straightforward removal of this component.

  • Activation implementation classes removed
  • Activation tests removed
  • adjustments to various comments to remove references to Activation
  • adjustments to some code to remove special-case support for Activation from core RMI
  • adjustments to several tests to remove testing and support for, and mentions of Activation
  • remove rmid tool

(Personally, I found that reviewing using the webrev was easier than navigating github's diff viewer.)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4194/head:pull/4194
$ git checkout pull/4194

Update a local copy of the PR:
$ git checkout pull/4194
$ git pull https://git.openjdk.java.net/jdk pull/4194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4194

View PR using the GUI difftool:
$ git pr show -t 4194

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4194.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2021

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 25, 2021

@stuart-marks The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • hotspot-runtime
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels May 25, 2021
@stuart-marks stuart-marks marked this pull request as ready for review May 25, 2021 18:56
@openjdk openjdk bot added the rfr Pull request is ready for review label May 25, 2021
@mlbridge
Copy link

mlbridge bot commented May 25, 2021

Webrevs

Copy link
Member

@erikj79 erikj79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build changes look good.

@openjdk
Copy link

openjdk bot commented May 25, 2021

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267123: Remove RMI Activation

Reviewed-by: erikj, rriggs, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 42 new commits pushed to the master branch:

  • 37bc4e2: 8263635: Add --servername option to jhsdb debugd
  • 6ffa3e6: 8267754: cds/appcds/loaderConstraints/LoaderConstraintsTest.java fails on x86_32 due to customized class loader is not supported
  • 1899f02: 8267805: Add UseVtableBasedCHA to the list of JVM flags known to jtreg
  • 0fc7c8d: 8267751: (test) jtreg.SkippedException has no serial VersionUID
  • a859d87: 8267721: Enable sun/security/pkcs11 tests for Amazon Linux 2 AArch64
  • e630235: 8266851: Implement JEP 403: Strongly Encapsulate JDK Internals
  • 8c4719a: 8265248: Implementation Specific Properties: change prefix, plus add existing properties
  • c59484e: 8267653: Remove Mutex::_safepoint_check_sometimes
  • de91643: 8267611: Print more info when pointer_delta assert fails
  • a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current
  • ... and 32 more: https://git.openjdk.java.net/jdk/compare/c519ba2e437a05ac83e53b358b6a02b2f6e20563...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 25, 2021
@AlanBateman
Copy link
Contributor

One other test that might need an update is test/jdk/sun/rmi/log/ReliableLog/LogAlignmentTest.java, it might be just the summary.

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuart-marks
Copy link
Member Author

AlanBateman wrote:

test/jdk/sun/rmi/log/ReliableLog/LogAlignmentTest.java

Oh yes, this test mentions rmid, but it is basically a direct test of the ReliableLog stuff and it doesn't actually use or depend on Activation or rmid. The test still runs and passes.

I'll do a followup pass to see if anything in the system uses anything in the sun.rmi.log package. Maybe the only user was Activation.

@stuart-marks
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this May 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@stuart-marks Since your change was applied there have been 52 commits pushed to the master branch:

  • 0754266: 8267709: Investigate differences between HtmlStyle and stylesheet.css
  • 23189a1: 8191786: Thread-SMR hash table size should be dynamic
  • ef368b3: 8265836: OperatingSystemImpl.getCpuLoad() returns incorrect CPU load inside a container
  • 10a6f5d: 8230623: Extract command-line help for -Xlint sub-options to new --help-lint
  • bea4109: 8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar
  • ec65cf8: 8240347: remove undocumented options from jlink --help message
  • 3623abb: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles
  • 85f6165: 8267817: [TEST] Remove unnecessary init in test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench:setup
  • 7278f56: 8267800: Remove the '_dirty' set in BCEscapeAnalyzer
  • bfa46f0: 8252476: as_Worker_thread() doesn't check what it intends
  • ... and 42 more: https://git.openjdk.java.net/jdk/compare/c519ba2e437a05ac83e53b358b6a02b2f6e20563...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7c85f35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
4 participants