Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8267709: Investigate differences between HtmlStyle and stylesheet.css #4195

Closed

Conversation

jonathan-gibbons
Copy link
Contributor

@jonathan-gibbons jonathan-gibbons commented May 25, 2021

Please review a new test to track the differences between HtmlStyle.java and stylesheet.css.

The test passes, because all discrepancies are noted within the test. However, some of the discrepancies may indicate the need for follow-up work, such as adding new items to HtmlStyle for documentation purposes, or removing unused code in the main stylesheet.css file.

There is also a minor/trivial change to fix a copy-paste error in a comment in HtmlStyle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267709: Investigate differences between HtmlStyle and stylesheet.css

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4195/head:pull/4195
$ git checkout pull/4195

Update a local copy of the PR:
$ git checkout pull/4195
$ git pull https://git.openjdk.java.net/jdk pull/4195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4195

View PR using the GUI difftool:
$ git pr show -t 4195

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4195.diff

@jonathan-gibbons jonathan-gibbons marked this pull request as draft May 25, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2021

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 25, 2021

@jonathan-gibbons The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc label May 25, 2021
@jonathan-gibbons jonathan-gibbons marked this pull request as ready for review May 26, 2021
@openjdk openjdk bot added the rfr label May 26, 2021
@mlbridge
Copy link

mlbridge bot commented May 26, 2021

Webrevs

removeAll(styleSheetNames, "all-classes-container", "all-packages-container",
"bottom-nav", "clear", "constant-values-container", "deprecated-content",
"footer", "hidden", "override-specify-label", "serialized-class-details",
"tab", "table-sub-heading-color");
Copy link
Member

@hns hns May 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be removed? Are we planning to do that in a separate issue?

hns
hns approved these changes May 27, 2021
Copy link
Member

@hns hns left a comment

The new test looks good, apart from the question whether we should remove unused styles now, later, or not at all.

@openjdk
Copy link

openjdk bot commented May 27, 2021

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267709: Investigate differences between HtmlStyle and stylesheet.css

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 10a6f5d: 8230623: Extract command-line help for -Xlint sub-options to new --help-lint
  • bea4109: 8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar
  • ec65cf8: 8240347: remove undocumented options from jlink --help message
  • 3623abb: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles
  • 85f6165: 8267817: [TEST] Remove unnecessary init in test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench:setup
  • 7278f56: 8267800: Remove the '_dirty' set in BCEscapeAnalyzer
  • bfa46f0: 8252476: as_Worker_thread() doesn't check what it intends
  • 37bc4e2: 8263635: Add --servername option to jhsdb debugd
  • 6ffa3e6: 8267754: cds/appcds/loaderConstraints/LoaderConstraintsTest.java fails on x86_32 due to customized class loader is not supported
  • 1899f02: 8267805: Add UseVtableBasedCHA to the list of JVM flags known to jtreg
  • ... and 23 more: https://git.openjdk.java.net/jdk/compare/594d4544759a240690ed4c0432c8140b852aea5a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 27, 2021
@jonathan-gibbons
Copy link
Contributor Author

jonathan-gibbons commented May 27, 2021

The new test looks good, apart from the question whether we should remove unused styles now, later, or not at all.

I was thinking to remove the unused styles in a separate PR. I wasn't sure if this would need extra investigation/verification that these styles are really unused.

@jonathan-gibbons
Copy link
Contributor Author

jonathan-gibbons commented May 27, 2021

/integrate

@openjdk openjdk bot closed this May 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@jonathan-gibbons Since your change was applied there have been 35 commits pushed to the master branch:

  • 23189a1: 8191786: Thread-SMR hash table size should be dynamic
  • ef368b3: 8265836: OperatingSystemImpl.getCpuLoad() returns incorrect CPU load inside a container
  • 10a6f5d: 8230623: Extract command-line help for -Xlint sub-options to new --help-lint
  • bea4109: 8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar
  • ec65cf8: 8240347: remove undocumented options from jlink --help message
  • 3623abb: 8263087: Add a MethodHandle combinator that switches over a set of MethodHandles
  • 85f6165: 8267817: [TEST] Remove unnecessary init in test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench:setup
  • 7278f56: 8267800: Remove the '_dirty' set in BCEscapeAnalyzer
  • bfa46f0: 8252476: as_Worker_thread() doesn't check what it intends
  • 37bc4e2: 8263635: Add --servername option to jhsdb debugd
  • ... and 25 more: https://git.openjdk.java.net/jdk/compare/594d4544759a240690ed4c0432c8140b852aea5a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0754266.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jonathan-gibbons jonathan-gibbons deleted the cssname-diffs branch Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated javadoc
2 participants