Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267750: Incomplete fix for JDK-8267683 #4196

Closed
wants to merge 1 commit into from
Closed

8267750: Incomplete fix for JDK-8267683 #4196

wants to merge 1 commit into from

Conversation

bradfordwetmore
Copy link
Contributor

@bradfordwetmore bradfordwetmore commented May 26, 2021

Missed updating today's changeset with the new variable name.

It's a "one character fix."


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4196/head:pull/4196
$ git checkout pull/4196

Update a local copy of the PR:
$ git checkout pull/4196
$ git pull https://git.openjdk.java.net/jdk pull/4196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4196

View PR using the GUI difftool:
$ git pr show -t 4196

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4196.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 26, 2021

👋 Welcome back wetmore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@bradfordwetmore The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security net labels May 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 26, 2021

Webrevs

jnimeh
jnimeh approved these changes May 26, 2021
Copy link
Member

@jnimeh jnimeh left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@bradfordwetmore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267750: Incomplete fix for JDK-8267683

Reviewed-by: jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ac36b7d: 8267452: Delegate forEachRemaining in Spliterators.iterator()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 26, 2021
@bradfordwetmore
Copy link
Contributor Author

@bradfordwetmore bradfordwetmore commented May 26, 2021

/integrate

@openjdk openjdk bot closed this May 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@bradfordwetmore Since your change was applied there has been 1 commit pushed to the master branch:

  • ac36b7d: 8267452: Delegate forEachRemaining in Spliterators.iterator()

Your commit was automatically rebased without conflicts.

Pushed as commit b33b8bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bradfordwetmore bradfordwetmore deleted the JDK-8267750 branch May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net security
2 participants