Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267751: (test) jtreg.SkippedException has no serial VersionUID #4197

Closed
wants to merge 2 commits into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented May 26, 2021

The class test/lib/jtreg/SkippedException.java is missing a serialVersionUID causing additional noise in compiler output of tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267751: (test) jtreg.SkippedException has no serial VersionUID

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4197/head:pull/4197
$ git checkout pull/4197

Update a local copy of the PR:
$ git checkout pull/4197
$ git pull https://git.openjdk.java.net/jdk pull/4197/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4197

View PR using the GUI difftool:
$ git pr show -t 4197

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4197.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 26, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@RogerRiggs To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@RogerRiggs
Copy link
Contributor Author

@RogerRiggs RogerRiggs commented May 26, 2021

/label core-libs

@openjdk openjdk bot added the core-libs label May 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@RogerRiggs
The core-libs label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 26, 2021

Webrevs

naotoj
naotoj approved these changes May 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267751: (test) jtreg.SkippedException has no serial VersionUID

Reviewed-by: naoto, iignatyev, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

  • de91643: 8267611: Print more info when pointer_delta assert fails
  • a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current
  • 9c346a1: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue
  • 45e0597: 8264302: Create implementation for Accessibility native peer for Splitpane java role
  • 4343997: 8267708: Remove references to com.sun.tools.javadoc.**
  • f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
  • bf8d4a8: 8267583: jmod fails on symlink to class file
  • 083416d: 8267130: Memory Overflow in Disassembler::load_library
  • 9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
  • 0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
  • ... and 67 more: https://git.openjdk.java.net/jdk/compare/9425d3de83fe8f4caddef03ffa3f4dd4de58f236...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 26, 2021
Copy link
Member

@iignatev iignatev left a comment

LGTM

@RogerRiggs
Copy link
Contributor Author

@RogerRiggs RogerRiggs commented May 26, 2021

/integrate

@openjdk openjdk bot closed this May 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 26, 2021

@RogerRiggs Since your change was applied there have been 81 commits pushed to the master branch:

  • a859d87: 8267721: Enable sun/security/pkcs11 tests for Amazon Linux 2 AArch64
  • e630235: 8266851: Implement JEP 403: Strongly Encapsulate JDK Internals
  • 8c4719a: 8265248: Implementation Specific Properties: change prefix, plus add existing properties
  • c59484e: 8267653: Remove Mutex::_safepoint_check_sometimes
  • de91643: 8267611: Print more info when pointer_delta assert fails
  • a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current
  • 9c346a1: 8266963: Remove safepoint poll introduced in 8262443 due to reentrance issue
  • 45e0597: 8264302: Create implementation for Accessibility native peer for Splitpane java role
  • 4343997: 8267708: Remove references to com.sun.tools.javadoc.**
  • f632254: 8267221: jshell feedback is incorrect when creating method with array varargs parameter
  • ... and 71 more: https://git.openjdk.java.net/jdk/compare/9425d3de83fe8f4caddef03ffa3f4dd4de58f236...master

Your commit was automatically rebased without conflicts.

Pushed as commit 0fc7c8d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8267751-skipped-suid branch Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
4 participants