8267583: jmod fails on symlink to class file

[sundararajana]

FileVisitOption.FOLLOW_LINKS used. Test extended for file symlinks case.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267583: jmod fails on symlink to class file

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4202/head:pull/4202
$ git checkout pull/4202

Update a local copy of the PR:
$ git checkout pull/4202
$ git pull https://git.openjdk.java.net/jdk pull/4202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4202

View PR using the GUI difftool:
$ git pr show -t 4202

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4202.diff

[bridgekeeper]

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sundararajana The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (601bf577)

[AlanBateman]

It strikes me a bit unusual to be following sym links here but okay.

[openjdk]

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267583: jmod fails on symlink to class file

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• 9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
• 0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
• b33b8bc: 8267750: Incomplete fix for JDK-8267683
• ac36b7d: 8267452: Delegate forEachRemaining in Spliterators.iterator()
• d0d2ddc: 8267651: runtime/handshake/HandshakeTimeoutTest.java times out when dumping core
• a98e476: 8267311: vmTestbase/gc/gctests/StringInternGC/StringInternGC.java eventually OOMEs
• 5aa45f2: 8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package"
• c20ca42: 8267691: Change table to obsolete CriticalJNINatives in JDK 18, not 17
• e751b7b: 8267683: rfc7301Grease8F value not displayed correctly in SSLParameters javadoc
• 0b77359: 8224243: Add implSpec's to AccessibleObject and seal Executable
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/a52c4ede2f043b7d4a234c7d06f91871312e9654...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sundararajana]

/integrate

[openjdk]

@sundararajana Since your change was applied there have been 18 commits pushed to the master branch:

• 083416d: 8267130: Memory Overflow in Disassembler::load_library
• 9d305b9: 8252372: Check if cloning is required to move loads out of loops in PhaseIdealLoop::split_if_with_blocks_post()
• 0394416: 8267468: Rename refill waster counters in ThreadLocalAllocBuffer
• b33b8bc: 8267750: Incomplete fix for JDK-8267683
• ac36b7d: 8267452: Delegate forEachRemaining in Spliterators.iterator()
• d0d2ddc: 8267651: runtime/handshake/HandshakeTimeoutTest.java times out when dumping core
• a98e476: 8267311: vmTestbase/gc/gctests/StringInternGC/StringInternGC.java eventually OOMEs
• 5aa45f2: 8267403: tools/jpackage/share/FileAssociationsTest.java#id0 failed with "Error: Bundler "Mac PKG Package" (pkg) failed to produce a package"
• c20ca42: 8267691: Change table to obsolete CriticalJNINatives in JDK 18, not 17
• e751b7b: 8267683: rfc7301Grease8F value not displayed correctly in SSLParameters javadoc
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/a52c4ede2f043b7d4a234c7d06f91871312e9654...master

Your commit was automatically rebased without conflicts.

Pushed as commit bf8d4a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.