8267800: Remove the '_dirty' set in BCEscapeAnalyzer

[D-D-H]

Hi,

Could I have a review of this change?

The content of _dirty in BCEscapeAnalyzer is only updated when processing _aaload. And it will not affect the results of the analysis because its content is never used.
IIUC, I think we should remove this set.

Thanks,
Denghui

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267800: Remove the '_dirty' set in BCEscapeAnalyzer

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4208/head:pull/4208
$ git checkout pull/4208

Update a local copy of the PR:
$ git checkout pull/4208
$ git pull https://git.openjdk.java.net/jdk pull/4208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4208

View PR using the GUI difftool:
$ git pr show -t 4208

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4208.diff

[bridgekeeper]

👋 Welcome back ddong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@D-D-H The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8a1dcf23)

[dean-long]

I did a little source code archeology, and _dirty was used when bcEscapeAnalyzer.cpp was added by https://bugs.openjdk.java.net/browse/JDK-6339956. But the changes made by https://bugs.openjdk.java.net/browse/JDK-6488063 caused _dirty to be unused.

[vnkozlov]

It was used to set _return_local. But it was changed long ago.

[openjdk]

@D-D-H This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267800: Remove the '_dirty' set in BCEscapeAnalyzer

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 37bc4e2: 8263635: Add --servername option to jhsdb debugd
• 6ffa3e6: 8267754: cds/appcds/loaderConstraints/LoaderConstraintsTest.java fails on x86_32 due to customized class loader is not supported
• 1899f02: 8267805: Add UseVtableBasedCHA to the list of JVM flags known to jtreg
• 0fc7c8d: 8267751: (test) jtreg.SkippedException has no serial VersionUID
• a859d87: 8267721: Enable sun/security/pkcs11 tests for Amazon Linux 2 AArch64
• e630235: 8266851: Implement JEP 403: Strongly Encapsulate JDK Internals
• 8c4719a: 8265248: Implementation Specific Properties: change prefix, plus add existing properties
• c59484e: 8267653: Remove Mutex::_safepoint_check_sometimes
• de91643: 8267611: Print more info when pointer_delta assert fails
• a4c46e1: 8263202: Update Hebrew/Indonesian/Yiddish ISO 639 language codes to current

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[D-D-H]

/integrate

[openjdk]

@D-D-H
Your change (at version 8a1dcf2) is now ready to be sponsored by a Committer.

[TobiHartmann]

Looks good.

/sponsor

[D-D-H]

Hi @TobiHartmann ,

It seems that your /sponsor didn't take effect, could you sponsor it again?

Best,
Denghui

[TobiHartmann]

/sponsor

[openjdk]

@TobiHartmann @D-D-H Since your change was applied there have been 11 commits pushed to the master branch:

• bfa46f0: 8252476: as_Worker_thread() doesn't check what it intends
• 37bc4e2: 8263635: Add --servername option to jhsdb debugd
• 6ffa3e6: 8267754: cds/appcds/loaderConstraints/LoaderConstraintsTest.java fails on x86_32 due to customized class loader is not supported
• 1899f02: 8267805: Add UseVtableBasedCHA to the list of JVM flags known to jtreg
• 0fc7c8d: 8267751: (test) jtreg.SkippedException has no serial VersionUID
• a859d87: 8267721: Enable sun/security/pkcs11 tests for Amazon Linux 2 AArch64
• e630235: 8266851: Implement JEP 403: Strongly Encapsulate JDK Internals
• 8c4719a: 8265248: Implementation Specific Properties: change prefix, plus add existing properties
• c59484e: 8267653: Remove Mutex::_safepoint_check_sometimes
• de91643: 8267611: Print more info when pointer_delta assert fails
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/9c346a1ec78b45c61fbfc76961dc5674cfd98520...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7278f56.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.