8267806: C1: Relax inlining checks for not yet initialized classes

[iwanowww]

The checks which guide inlining decisions in C1 are too strong: declaring holder class is required to be fully initialized while JVMS only mandates an initialization barrier on resolved class in invokestatic case.

The fix relaxes the checks to rule out only not yet linked classes unless it is an invokestatic call site.

Testing:

• hs-tier1 - hs-tier9

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267806: C1: Relax inlining checks for not yet initialized classes

Reviewers

• Roland Westrelin (@rwestrel - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4211/head:pull/4211
$ git checkout pull/4211

Update a local copy of the PR:
$ git checkout pull/4211
$ git pull https://git.openjdk.java.net/jdk pull/4211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4211

View PR using the GUI difftool:
$ git pr show -t 4211

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4211.diff

[bridgekeeper]

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[iwanowww]

/label add hotspot-compiler

[openjdk]

@iwanowww
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 00: Full (de963ffc)

[rwestrel]

Looks good to me.

[openjdk]

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267806: C1: Relax inlining checks for not yet initialized classes

Reviewed-by: roland, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 1d2c7ac: 8267555: Fix class file version during redefinition after 8238048
• 97ec5ad: 8265753: Remove manual JavaThread transitions to blocked
• 6eb9114: 8266877: Missing local debug information when debugging JEP-330
• 0c9daa7: 8265029: Preserve SIZED characteristics on slice operations (skip, limit)
• 95b1fa7: 8267529: StringJoiner can create a String that breaks String::equals
• 7f52c50: 8182043: Access to Windows Large Icons
• 8a31c07: 8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java
• ae258f1: 8265418: Clean-up redundant null-checks of Class.getPackageName()
• 41185d3: 8229517: Support for optional asynchronous/buffered logging
• 7c85f35: 8267123: Remove RMI Activation
• ... and 54 more: https://git.openjdk.java.net/jdk/compare/ebc9357d58957702abbd003d21082badc630876d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Looks good to me too.

[iwanowww]

Thanks for the reviews, Roland and Tobias.

/integrate

[openjdk]

@iwanowww Since your change was applied there have been 74 commits pushed to the master branch:

• 1e29005: 8267842: SIGSEGV in get_current_contended_monitor
• 236bd89: 8263583: Emoji rendering on macOS
• 1ab2776: 8247608: Javadoc: CSS margin is not applied consistently
• 9031477: 8267945: ZGC: Revert NUMA changes (JDK-8266217 and JDK-8241354) after JDK-8241423
• 6627432: 8267953: restore 'volatile' to ObjectMonitor::_owner field
• 964bac9: 8267706: bin/idea.sh tries to use cygpath on WSL
• 591b0c3: 8264624: change the guarantee() calls added by JDK-8264123 to assert() calls
• 0c0ff7f: 8265309: com/sun/jndi/dns/ConfigTests/Timeout.java fails with "Address already in use" BindException
• 24bf35f: 8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with "IOException: No buffer space available"
• 1413f9e: 8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default
• ... and 64 more: https://git.openjdk.java.net/jdk/compare/ebc9357d58957702abbd003d21082badc630876d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 35916ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.