Skip to content

8267817: [TEST] Remove unnecessary init in test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench:setup #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dongbohe
Copy link
Member

@dongbohe dongbohe commented May 27, 2021

decryptCipher will be reinitialized in decrypt, which will loses all previously-acquired state. Therefore, it's not necessary to initialize in setup.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267817: [TEST] Remove unnecessary init in test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench:setup

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4215/head:pull/4215
$ git checkout pull/4215

Update a local copy of the PR:
$ git checkout pull/4215
$ git pull https://git.openjdk.java.net/jdk pull/4215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4215

View PR using the GUI difftool:
$ git pr show -t 4215

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4215.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2021

👋 Welcome back dongbohe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@dongbohe The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 27, 2021
@mlbridge
Copy link

mlbridge bot commented May 27, 2021

Webrevs

Copy link
Member

@cl4es cl4es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented May 27, 2021

@dongbohe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267817: [TEST] Remove unnecessary init in test/micro/org/openjdk/bench/javax/crypto/full/AESGCMBench:setup

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 7278f56: 8267800: Remove the '_dirty' set in BCEscapeAnalyzer
  • bfa46f0: 8252476: as_Worker_thread() doesn't check what it intends
  • 37bc4e2: 8263635: Add --servername option to jhsdb debugd

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@cl4es) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 27, 2021
@dongbohe
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@dongbohe
Your change (at version b75ae84) is now ready to be sponsored by a Committer.

@cl4es
Copy link
Member

cl4es commented May 27, 2021

/sponsor

@openjdk openjdk bot closed this May 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@cl4es @dongbohe Since your change was applied there have been 3 commits pushed to the master branch:

  • 7278f56: 8267800: Remove the '_dirty' set in BCEscapeAnalyzer
  • bfa46f0: 8252476: as_Worker_thread() doesn't check what it intends
  • 37bc4e2: 8263635: Add --servername option to jhsdb debugd

Your commit was automatically rebased without conflicts.

Pushed as commit 85f6165.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants