JDK-8267839: trivial mem leak in numa

[Hamlin-Li]

There is a trivial mem leak in numa related code. This patch is to use a stored bitmask* rather than get a new one.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267839: trivial mem leak in numa

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Stefan Johansson (@kstefanj - Reviewer)

Contributors

• Shoubing Ma <mashoubing1@huawei.com>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4219/head:pull/4219
$ git checkout pull/4219

Update a local copy of the PR:
$ git checkout pull/4219
$ git pull https://git.openjdk.java.net/jdk pull/4219/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4219

View PR using the GUI difftool:
$ git pr show -t 4219

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4219.diff

[bridgekeeper]

👋 Welcome back mli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[Hamlin-Li]

/contributor add Shoubing Ma mashoubing1@huawei.com

[openjdk]

@Hamlin-Li
Contributor Shoubing Ma <mashoubing1@huawei.com> successfully added.

[openjdk]

@Hamlin-Li The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d54c5ea1)

[tschatzl]

Lgtm. Please wait for a second reviewer, preferably from the runtime team, before pushing this.

[openjdk]

@Hamlin-Li This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267839: trivial mem leak in numa

Co-authored-by: Shoubing Ma <mashoubing1@huawei.com>
Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 281 new commits pushed to the master branch:

• 74b70a5: 8036580: CHA: improve default method support
• 20479c3: 8065760: CHA: Improve abstract method support
• 68f3b3a: 8267807: C2: Downcast receiver to target holder during inlining
• 1c7c0e1: 8267937: Wrong indentation in G1 gc+phases log for free cset subphases
• ffd28c4: 8267947: CI: Preserve consistency between has_subklass() and is_subclass_of()
• 229a6e2: 8267095: Miscellaneous cleanups in vm.runtime.defmeth tests
• 6149b9a: 8267914: Remove DeferredObjectToKlass workaround
• 4eb2168: 8267670: Update java.io, java.math, and java.text to use switch expressions
• f5634fe: 8267979: C2: Fix verification code in SubTypeCheckNode::Ideal()
• ae2f37f: 8267616: AArch64: Fix AES assertion messages in stubGenerator_aarch64.cpp
• ... and 271 more: https://git.openjdk.java.net/jdk/compare/0344e751e2bfd2c6238fc1cea3db19015ce0db88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[kstefanj]

The change looks good.

I know this pre-existing, but to me it feels a bit strange to return false if the NUMA-functions are available. Wouldn't it make more sense to return true, which would disable NUMA. This is not something we should change in this patch, just wanted to hear others opinions now when I stumbled upon this.

[Hamlin-Li]

@tschatzl @kstefanj Thanks for your review.

[Hamlin-Li]

/integrate

[openjdk]

@Hamlin-Li Since your change was applied there have been 376 commits pushed to the master branch:

• 52d88ee: 8268292: compiler/intrinsics/VectorizedMismatchTest.java fails with release VMs
• 042f0bd: 8256465: [macos] Java frame and dialog presented full screen freeze application
• 8abf36c: 8268289: build failure due to missing signed flag in x86 evcmpb instruction
• b05c40c: 8266951: Partial in-lining for vectorized mismatch operation using AVX512 masked instructions
• f768fbf: 8268286: ProblemList serviceability/sa/TestJmapCore.java on linux-aarch64 with ZGC
• b2e9eb9: 8268087: Update documentation of the JPasswordField
• 91f9adc: 8268139: CDS ArchiveBuilder may reference unloaded classes
• 36bff6f: 8066694: Strange code in JavacParser.java
• 6c838c5: 8266846: Add java.time.InstantSource
• 7f55dc1: 8179880: Refactor javax/security shell tests to plain java tests
• ... and 366 more: https://git.openjdk.java.net/jdk/compare/0344e751e2bfd2c6238fc1cea3db19015ce0db88...master

Your commit was automatically rebased without conflicts.

Pushed as commit 95ddf7d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.