Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8179880: Refactor javax/security shell tests to plain java tests #4220

Closed
wants to merge 1 commit into from

Conversation

sisahoo
Copy link
Member

@sisahoo sisahoo commented May 27, 2021

This change converts JTREG shell Test scripts to Java equivalent.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8179880: Refactor javax/security shell tests to plain java tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4220/head:pull/4220
$ git checkout pull/4220

Update a local copy of the PR:
$ git checkout pull/4220
$ git pull https://git.openjdk.java.net/jdk pull/4220/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4220

View PR using the GUI difftool:
$ git pr show -t 4220

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4220.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2021

👋 Welcome back ssahoo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@sisahoo The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label May 27, 2021
@mlbridge
Copy link

mlbridge bot commented May 27, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 4, 2021

@sisahoo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8179880: Refactor javax/security shell tests to plain java tests

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 144 new commits pushed to the master branch:

  • 59a539f: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries
  • 40c9e25: 8265444: Javadocs: jdk.jshell - small typo
  • 069f180: 8268174: Move x86-specific stub declarations into stubRoutines_x86.hpp
  • 3025f05: 8264305: Create implementation for native accessibility peer for Statusbar java role
  • e2d5ff9: 8268214: Use system zlib and disable dtrace when building linux-aarch64 at Oracle
  • 1b4378e: 8268142: Switch to jdk-17+24 for macosx-aarch64 at Oracle
  • edca245: 8267917: mark hotspot containers tests which ignore external VM flags
  • 05df172: 8268224: Cleanup references to "strictfp" in core lib comments
  • 516e60a: 8268095: CDS MethodHandle tests should add -XX:-VerifyDependencies
  • c1f3094: 8267939: Clarify the specification of iterator and spliterator forEachRemaining
  • ... and 134 more: https://git.openjdk.java.net/jdk/compare/039441689d21f3dccf515bb2be89608b0772a235...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 4, 2021
@sisahoo
Copy link
Member Author

sisahoo commented Jun 5, 2021

/integrate

@openjdk openjdk bot closed this Jun 5, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2021
@openjdk
Copy link

openjdk bot commented Jun 5, 2021

@sisahoo Since your change was applied there have been 153 commits pushed to the master branch:

  • 7e41ca3: 8266957: SA has not followed JDK-8220587 and JDK-8224965
  • 6ff978a: 8267204: Expose access to underlying streams in Reporter
  • 76b54a1: 8263512: [macos_aarch64] issues with calling va_args functions from invoke_native
  • 4e6748c: 8267687: ModXNode::Ideal optimization is better than Parse::do_irem
  • 48dc72b: 8268272: Remove JDK-8264874 changes because Graal was removed.
  • 20b6312: 8268151: Vector API toShuffle optimization
  • 64ec8b3: 8212155: Race condition when posting dynamic_code_generated event leads to JVM crash
  • cd0678f: 8199318: add idempotent copy operation for Map.Entry
  • b27599b: 8268222: javax/xml/jaxp/unittest/transform/Bug6216226Test.java failed, cannot delete file
  • 59a539f: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries
  • ... and 143 more: https://git.openjdk.java.net/jdk/compare/039441689d21f3dccf515bb2be89608b0772a235...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7f55dc1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants