Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java #4231

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented May 27, 2021

A trivial fix to ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4231/head:pull/4231
$ git checkout pull/4231

Update a local copy of the PR:
$ git checkout pull/4231
$ git pull https://git.openjdk.java.net/jdk pull/4231/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4231

View PR using the GUI difftool:
$ git pr show -t 4231

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4231.diff

@dcubed-ojdk
Copy link
Member Author

/label add core-libs

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review May 27, 2021 20:18
@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.org labels May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@dcubed-ojdk
Copy link
Member Author

@stuart-marks - Thanks for the fast review.

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267886: ProblemList javax/management/remote/mandatory/connection/RMIConnector_NPETest.java

Reviewed-by: smarks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ae258f1: 8265418: Clean-up redundant null-checks of Class.getPackageName()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 27, 2021
@openjdk openjdk bot closed this May 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • ae258f1: 8265418: Clean-up redundant null-checks of Class.getPackageName()

Your commit was automatically rebased without conflicts.

Pushed as commit 8a31c07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented May 27, 2021

Webrevs

@dcubed-ojdk dcubed-ojdk deleted the JDK-8267886 branch May 28, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants