Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267569: java.io.File.equals contains misleading Javadoc #4232

Closed
wants to merge 3 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented May 27, 2021

Modify the specification of java.io.File.equals to clarify that equality is based only on a comparison of abstract pathnames as opposed to the file system objects that the Files represent.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267569: java.io.File.equals contains misleading Javadoc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4232/head:pull/4232
$ git checkout pull/4232

Update a local copy of the PR:
$ git checkout pull/4232
$ git pull https://git.openjdk.java.net/jdk pull/4232/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4232

View PR using the GUI difftool:
$ git pr show -t 4232

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4232.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2021

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bplb
Copy link
Member Author

bplb commented May 27, 2021

/csr

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@bplb this pull request will not be integrated until the CSR request JDK-8267889 for issue JDK-8267569 has been approved.

@openjdk
Copy link

openjdk bot commented May 27, 2021

@bplb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 27, 2021
@mlbridge
Copy link

mlbridge bot commented May 27, 2021

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jun 1, 2021
@openjdk
Copy link

openjdk bot commented Jun 1, 2021

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267569: java.io.File.equals contains misleading Javadoc

Reviewed-by: alanb, dfuchs, bchristi, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 228 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2021
@bplb
Copy link
Member Author

bplb commented Jun 2, 2021

/integrate

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@bplb Since your change was applied there have been 252 commits pushed to the master branch:

  • 508cec7: 8267521: Post JEP 411 refactoring: maximum covering > 50K
  • 40d23a0: 8267543: Post JEP 411 refactoring: security
  • 4767758: 8267920: Create separate Events buffer for VMOperations
  • dc19bac: 8268094: Some vmTestbase/nsk tests fail after ACC_STRICT/strictfp changes
  • 2963c9e: 8268103: JNI functions incorrectly return a double after JDK-8265836
  • 6765f90: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal
  • 19450b9: 8266281: Assign Symbols to the package selector expression
  • a223189: 8264774: Implementation of Foreign Function and Memory API (Incubator)
  • 71425dd: 8267118: OutOfMemoryError cannot be caught as a Throwable
  • de6472c: 8267459: Pasting Unicode characters into JShell does not work.
  • ... and 242 more: https://git.openjdk.java.net/jdk/compare/e90388bc1e7bba92675fa799d9da77aa4d6e1a05...master

Your commit was automatically rebased without conflicts.

Pushed as commit 56b65e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the File-equals-8267569 branch June 2, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants