8266239: Some duplicated javac command-line options have repeated effect

[lgxbslgx]

Hi all,

Some duplicated info options (--version, --help, --help-extra, --help-lint, --full-version) have repeated effect. Please see the following example.

$ javac -version -version
javac 17-internal
javac 17-internal

The patch fixes it and adds a corresponding test case.
Thank you for taking the time to review.

Best Regards,
-- Guoxiong

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8266239: Some duplicated javac command-line options have repeated effect

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4244/head:pull/4244
$ git checkout pull/4244

Update a local copy of the PR:
$ git checkout pull/4244
$ git pull https://git.openjdk.java.net/jdk pull/4244/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4244

View PR using the GUI difftool:
$ git pr show -t 4244

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4244.diff

[bridgekeeper]

👋 Welcome back gli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lgxbslgx The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (d297a47e)

[lgxbslgx]

/csr

[openjdk]

@lgxbslgx this pull request will not be integrated until the CSR request JDK-8267955 for issue JDK-8266239 has been approved.

[bridgekeeper]

@lgxbslgx This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@lgxbslgx This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[lgxbslgx]

/open

[openjdk]

@lgxbslgx @HostUserDetails{id=13688759, username='lgxbslgx', fullName='null'} this pull request is now open

[bridgekeeper]

@lgxbslgx This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[lgxbslgx]

The CSR has been approved. Ping for review.

[vicente-romero-oracle]

lgtm

[openjdk]

@lgxbslgx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266239: Some duplicated javac command-line options have repeated effect

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1240 new commits pushed to the master branch:

• 7fff22a: 8272805: Avoid looking up standard charsets
• 92b05fe: 8273251: Call check_possible_safepoint() from SafepointMechanism::process_if_requested()
• 29e0f13: 8272385: Enforce ECPrivateKey d value to be in the range [1, n-1] for SunEC provider
• aaa6f69: 8273250: Address javadoc issues in Deflater::setDictionationary
• 5ee5dd9: 8272914: Create hotspot:tier2 and hotspot:tier3 test groups
• 5245c1c: 8273147: Update and restructure TestGCLogMessages log message list
• 632a7e0: 8273165: GraphKit::combine_exception_states fails with "matching stack sizes" assert
• c2e015c: 8273229: Update OS detection code to recognize Windows Server 2022
• 0c1b16b: 8273243: Fix indentations in java.net.InetAddress methods
• 152e669: 8273140: Replace usages of Enum.class.getEnumConstants() with Enum.values() where possible
• ... and 1230 more: https://git.openjdk.java.net/jdk/compare/ef368b32bc8609bdc46cda628fa25e9bcad751e3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lgxbslgx]

@vicente-romero-oracle Thanks for your review.

/integrate

[openjdk]

Going to push as commit d05494f.
Since your change was applied there have been 1245 commits pushed to the master branch:

• 93eec9a: 8272776: NullPointerException not reported
• 7b023a3: 8273257: jshell doesn't compile a sealed hierarchy with a sealed interface and a non-sealed leaf
• f17ee0c: 8273263: Incorrect recovery attribution of record component type when j.l.Record is unavailable
• fa9c865: 8273112: -Xloggc: should override -verbose:gc
• dd87181: 8214761: Bug in parallel Kahan summation implementation
• 7fff22a: 8272805: Avoid looking up standard charsets
• 92b05fe: 8273251: Call check_possible_safepoint() from SafepointMechanism::process_if_requested()
• 29e0f13: 8272385: Enforce ECPrivateKey d value to be in the range [1, n-1] for SunEC provider
• aaa6f69: 8273250: Address javadoc issues in Deflater::setDictionationary
• 5ee5dd9: 8272914: Create hotspot:tier2 and hotspot:tier3 test groups
• ... and 1235 more: https://git.openjdk.java.net/jdk/compare/ef368b32bc8609bdc46cda628fa25e9bcad751e3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lgxbslgx Pushed as commit d05494f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.