Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8247608: Javadoc: CSS margin is not applied consistently #4250

Closed
wants to merge 1 commit into from

Conversation

@hns
Copy link
Member

@hns hns commented May 28, 2021

This simple stylesheet change adds a 10px right side border to the <dd> element containing the contents of block tags. I'm attaching a screenshot with the fixed spacing, see JBS attachments for reproducer source code and before-screenshots.

border


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8247608: Javadoc: CSS margin is not applied consistently

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4250/head:pull/4250
$ git checkout pull/4250

Update a local copy of the PR:
$ git checkout pull/4250
$ git pull https://git.openjdk.java.net/jdk pull/4250/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4250

View PR using the GUI difftool:
$ git pr show -t 4250

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4250.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 28, 2021

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the javadoc label May 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 28, 2021

Webrevs

Loading

Copy link
Contributor

@jonathan-gibbons jonathan-gibbons left a comment

As a separate issue, I suggest that it might be good increase the margins for

so that it is slightly indented relative to the surrounding text.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8247608: Javadoc: CSS margin is not applied consistently

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 0c0ff7f: 8265309: com/sun/jndi/dns/ConfigTests/Timeout.java fails with "Address already in use" BindException
  • 24bf35f: 8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with "IOException: No buffer space available"
  • 1413f9e: 8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label May 28, 2021
@hns
Copy link
Member Author

@hns hns commented May 31, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 31, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 31, 2021

@hns Since your change was applied there have been 7 commits pushed to the master branch:

  • 9031477: 8267945: ZGC: Revert NUMA changes (JDK-8266217 and JDK-8241354) after JDK-8241423
  • 6627432: 8267953: restore 'volatile' to ObjectMonitor::_owner field
  • 964bac9: 8267706: bin/idea.sh tries to use cygpath on WSL
  • 591b0c3: 8264624: change the guarantee() calls added by JDK-8264123 to assert() calls
  • 0c0ff7f: 8265309: com/sun/jndi/dns/ConfigTests/Timeout.java fails with "Address already in use" BindException
  • 24bf35f: 8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with "IOException: No buffer space available"
  • 1413f9e: 8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default

Your commit was automatically rebased without conflicts.

Pushed as commit 1ab2776.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants