Skip to content

Conversation

@JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented May 29, 2021

Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping. Clarifies the supported types for the evaluateExpression methods.

Other changes were javadoc tag usages, e.g. s/the code tag/{@code

/csr


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4258/head:pull/4258
$ git checkout pull/4258

Update a local copy of the PR:
$ git checkout pull/4258
$ git pull https://git.openjdk.java.net/jdk pull/4258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4258

View PR using the GUI difftool:
$ git pr show -t 4258

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4258.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 29, 2021

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 29, 2021
@openjdk
Copy link

openjdk bot commented May 29, 2021

@JoeWang-Java the issue for this pull request, JDK-8266559, already has an approved CSR request: JDK-8267809

@openjdk
Copy link

openjdk bot commented May 29, 2021

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 29, 2021
@mlbridge
Copy link

mlbridge bot commented May 29, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 1, 2021

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2021
*
* <p>
* Of the subtypes of Number, only Double, Integer and Long are supported.
* Of the subtypes of Number, only {@code Double, Integer} and {@code Long} are supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Number may also be in @code emphasis.

@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@JoeWang-Java Since your change was applied there have been 42 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 7530c00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8266559 branch June 2, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants