Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267616: AArch64: Fix AES assertion messages in stubGenerator_aarch64.cpp #4259

Closed
wants to merge 1 commit into from

Conversation

@dgbo
Copy link
Member

@dgbo dgbo commented May 29, 2021

Trivial fix for the messages of assert(UseAES, "need AES instructions and misaligned SSE support") in stubGenerator_aarch64.cpp.
The SSE instruction set is an extension to the x86 architecture. On aarch64, AES cryptographic extension are used for these intrinsics.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267616: AArch64: Fix AES assertion messages in stubGenerator_aarch64.cpp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4259/head:pull/4259
$ git checkout pull/4259

Update a local copy of the PR:
$ git checkout pull/4259
$ git pull https://git.openjdk.java.net/jdk pull/4259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4259

View PR using the GUI difftool:
$ git pr show -t 4259

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4259.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 29, 2021

👋 Welcome back dongbo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label May 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@dgbo The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 29, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@dgbo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267616: AArch64: Fix AES assertion messages in stubGenerator_aarch64.cpp

Reviewed-by: aph, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

  • 1ab2776: 8247608: Javadoc: CSS margin is not applied consistently
  • 9031477: 8267945: ZGC: Revert NUMA changes (JDK-8266217 and JDK-8241354) after JDK-8241423
  • 6627432: 8267953: restore 'volatile' to ObjectMonitor::_owner field
  • 964bac9: 8267706: bin/idea.sh tries to use cygpath on WSL
  • 591b0c3: 8264624: change the guarantee() calls added by JDK-8264123 to assert() calls
  • 0c0ff7f: 8265309: com/sun/jndi/dns/ConfigTests/Timeout.java fails with "Address already in use" BindException
  • 24bf35f: 8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with "IOException: No buffer space available"
  • 1413f9e: 8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default
  • 1d2c7ac: 8267555: Fix class file version during redefinition after 8238048
  • 97ec5ad: 8265753: Remove manual JavaThread transitions to blocked
  • ... and 72 more: https://git.openjdk.java.net/jdk/compare/f4531661b55458554f907ba988eca22b72c72bf3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph, @neliasso) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label May 29, 2021
@dgbo
Copy link
Member Author

@dgbo dgbo commented May 29, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label May 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@dgbo
Your change (at version 614cb4d) is now ready to be sponsored by a Committer.

Loading

Copy link
Contributor

@neliasso neliasso left a comment

Looks good.

Loading

@RealFYang
Copy link
Member

@RealFYang RealFYang commented Jun 1, 2021

/sponsor

Loading

@openjdk openjdk bot closed this Jun 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 1, 2021

@RealFYang @dgbo Since your change was applied there have been 95 commits pushed to the master branch:

  • c06db45: 8267921: Remove redundant loop from sun.reflect.misc.ReflectUtil.privateCheckPackageAccess()
  • 382e7ec: 8246351: elements in headings are of incorrect size
  • 5df25dc088cfc3069e451b48c4f013d1d0491aa2: 8266807: Windows os_windows-gtest broken for UseLargePages
  • ce44cd6881bcbef81a840d7961a951ba586c0eae: 8267845: Add @requires to avoid running G1 large pages test with wrong page size
  • 4ade125c8a53e0bdc105e5f65e8c1d7aa13db950: 8267934: remove dead code in CLD
  • bd31653e6f99d4337e4af1f7f138d688ec99c19d: 8267938: (sctp) SCTP channel factory methods should check platform support
  • 7ab6b4012026d4786a4c3937b559da9d3142a228: 8267375: Aarch64: JVM crashes with option -XX:PrintIdealGraphLevel=3 on SVE backend
  • 2c8e94f6804fee269a882a3e92b7ce844451eb11: 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder
  • 64f0f68958a74d4ee34c4b738759fc2278fa8b47: 8267464: Circular-dependency resilient inline headers
  • ab5a7ff2304dd4cb069ae2bbd6fdd99b3de7a6a3: 8267587: Update java.util to use enhanced switch
  • ... and 85 more: https://git.openjdk.java.net/jdk/compare/f4531661b55458554f907ba988eca22b72c72bf3...master

Your commit was automatically rebased without conflicts.

Pushed as commit ae2f37f868bfdcb3d46098e91ed537fb199d7dbe.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dgbo dgbo deleted the incorrect_AES_assertmsg branch Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants