New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253824: Revert JDK-8253089 since VS warning C4307 has been disabled #426
Conversation
Summary: This reverts commit 3f455f0.
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@RealCLanger, @TheRealMDoerr: need your help to test Windows MSVC 2017 builds here. I (un)fortunately lost the build capability with MSVC 2017. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and builds with VS2017.
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 37 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thanks for testing, @TheRealMDoerr! @iklam, want to take a look? |
/integrate |
@shipilev Since your change was applied there have been 37 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 60ec2a5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This reverts commit 3f455f0.
Testing:
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/426/head:pull/426
$ git checkout pull/426