Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267953: restore 'volatile' to ObjectMonitor::_owner field #4262

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented May 29, 2021

A trivial fix to restore 'volatile' to ObjectMonitor::_owner field.

This fix was tested with a Mach5 Tier job set.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267953: restore 'volatile' to ObjectMonitor::_owner field

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4262/head:pull/4262
$ git checkout pull/4262

Update a local copy of the PR:
$ git checkout pull/4262
$ git pull https://git.openjdk.java.net/jdk pull/4262/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4262

View PR using the GUI difftool:
$ git pr show -t 4262

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4262.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented May 29, 2021

/label add hotspot-runtime

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review May 29, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 29, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr hotspot-runtime labels May 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 29, 2021

Webrevs

Copy link
Contributor

@theRealAph theRealAph left a comment

Yes. I very much approve.

@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267953: restore 'volatile' to ObjectMonitor::_owner field

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 29, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented May 29, 2021

@theRealAph - Thanks for the review!

/integrate

@openjdk openjdk bot closed this May 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 29, 2021

@dcubed-ojdk Pushed as commit 6627432.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8267953 branch May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime integrated
2 participants