Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267921: Remove redundant loop from sun.reflect.misc.ReflectUtil.privateCheckPackageAccess() #4268

Closed
wants to merge 1 commit into from

Conversation

stsypanov
Copy link
Contributor

@stsypanov stsypanov commented May 31, 2021

This a tiny follop-up of #3571.

The loop in sun.reflect.misc.ReflectUtil.privateCheckPackageAccess() is redundant since Class.getPackageName() will already return the package name of the innermost component type.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267921: Remove redundant loop from sun.reflect.misc.ReflectUtil.privateCheckPackageAccess()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4268/head:pull/4268
$ git checkout pull/4268

Update a local copy of the PR:
$ git checkout pull/4268
$ git pull https://git.openjdk.java.net/jdk pull/4268/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4268

View PR using the GUI difftool:
$ git pr show -t 4268

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4268.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 31, 2021

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 31, 2021
@openjdk
Copy link

openjdk bot commented May 31, 2021

@stsypanov The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label May 31, 2021
@mlbridge
Copy link

mlbridge bot commented May 31, 2021

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getPackageName went through a few iterations in JDK 9 and this is probably a left over.

@openjdk
Copy link

openjdk bot commented May 31, 2021

⚠️ @stsypanov the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8267921
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented May 31, 2021

@stsypanov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267921: Remove redundant loop from sun.reflect.misc.ReflectUtil.privateCheckPackageAccess()

Reviewed-by: alanb, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 382e7ec: 8246351: elements in headings are of incorrect size
  • 5df25dc088cfc3069e451b48c4f013d1d0491aa2: 8266807: Windows os_windows-gtest broken for UseLargePages
  • ce44cd6881bcbef81a840d7961a951ba586c0eae: 8267845: Add @requires to avoid running G1 large pages test with wrong page size
  • 4ade125c8a53e0bdc105e5f65e8c1d7aa13db950: 8267934: remove dead code in CLD
  • bd31653e6f99d4337e4af1f7f138d688ec99c19d: 8267938: (sctp) SCTP channel factory methods should check platform support
  • 7ab6b4012026d4786a4c3937b559da9d3142a228: 8267375: Aarch64: JVM crashes with option -XX:PrintIdealGraphLevel=3 on SVE backend
  • 2c8e94f6804fee269a882a3e92b7ce844451eb11: 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder
  • 64f0f68958a74d4ee34c4b738759fc2278fa8b47: 8267464: Circular-dependency resilient inline headers
  • ab5a7ff2304dd4cb069ae2bbd6fdd99b3de7a6a3: 8267587: Update java.util to use enhanced switch
  • 35916ed57f425ea674de1e9d5023e7cf199a6740: 8267806: C1: Relax inlining checks for not yet initialized classes
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/1d2c7ac3f7492b335757bf0fd3f6ca3941c5fc72...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @mlchung) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 31, 2021
@stsypanov
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 31, 2021
@openjdk
Copy link

openjdk bot commented May 31, 2021

@stsypanov
Your change (at version fe180a1) is now ready to be sponsored by a Committer.

@mlchung
Copy link
Member

mlchung commented May 31, 2021

/sponsor

@openjdk openjdk bot closed this May 31, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 31, 2021
@openjdk
Copy link

openjdk bot commented May 31, 2021

@mlchung @stsypanov Since your change was applied there have been 20 commits pushed to the master branch:

  • 382e7ec: 8246351: elements in headings are of incorrect size
  • 5df25dc088cfc3069e451b48c4f013d1d0491aa2: 8266807: Windows os_windows-gtest broken for UseLargePages
  • ce44cd6881bcbef81a840d7961a951ba586c0eae: 8267845: Add @requires to avoid running G1 large pages test with wrong page size
  • 4ade125c8a53e0bdc105e5f65e8c1d7aa13db950: 8267934: remove dead code in CLD
  • bd31653e6f99d4337e4af1f7f138d688ec99c19d: 8267938: (sctp) SCTP channel factory methods should check platform support
  • 7ab6b4012026d4786a4c3937b559da9d3142a228: 8267375: Aarch64: JVM crashes with option -XX:PrintIdealGraphLevel=3 on SVE backend
  • 2c8e94f6804fee269a882a3e92b7ce844451eb11: 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder
  • 64f0f68958a74d4ee34c4b738759fc2278fa8b47: 8267464: Circular-dependency resilient inline headers
  • ab5a7ff2304dd4cb069ae2bbd6fdd99b3de7a6a3: 8267587: Update java.util to use enhanced switch
  • 35916ed57f425ea674de1e9d5023e7cf199a6740: 8267806: C1: Relax inlining checks for not yet initialized classes
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/1d2c7ac3f7492b335757bf0fd3f6ca3941c5fc72...master

Your commit was automatically rebased without conflicts.

Pushed as commit c06db45fa77c8a90518d6ff023de6c46b7c89997.

:bulb: You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stsypanov stsypanov deleted the 8267921 branch May 31, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants