Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267990: Revisit some uses of synchronized in the HttpClient API #4275

Closed
wants to merge 2 commits into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented May 31, 2021

The Utils.remaining(List list) method assumes that it can and should synchronize on the given list to prevent concurrent modification. In 99% of the cases this assumption is wrong. There's only one such list (the SSLFlowDelegate writeList) that requires this synchronization.

Also the SequentialScheduler.synchronizedScheduler uses synchronized, it could use a Lock instead and this would make it possible to assert that there is no contention (since the logic of the SequentialScheduler is supposed to prevent contention from occurring at this place).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267990: Revisit some uses of synchronized in the HttpClient API

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4275/head:pull/4275
$ git checkout pull/4275

Update a local copy of the PR:
$ git checkout pull/4275
$ git pull https://git.openjdk.java.net/jdk pull/4275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4275

View PR using the GUI difftool:
$ git pr show -t 4275

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4275.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 31, 2021

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 31, 2021

@dfuch The following labels will be automatically applied to this pull request:

  • net
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security net labels May 31, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 31, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 31, 2021

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267990: Revisit some uses of `synchronized` in the HttpClient API

Reviewed-by: chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 382e7ec: 8246351: elements in headings are of incorrect size
  • 5df25dc088cfc3069e451b48c4f013d1d0491aa2: 8266807: Windows os_windows-gtest broken for UseLargePages

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 31, 2021
@dfuch
Copy link
Member Author

@dfuch dfuch commented Jun 1, 2021

/integrate

@openjdk openjdk bot closed this Jun 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 1, 2021

@dfuch Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 9d8ad2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated net security
2 participants